Change signatures of filter bounds methods to return a rect.

Change signatures of filter bounds methods to return a rect.

Change filterBounds(), onFilterBounds() and onFilterNodeBounds() and computeFastBounds() to
return the destination rectangle. There was no code path that could
return false, and returning rects by value is ok now.

BUG=skia:5094
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1823573003

Committed: https://skia.googlesource.com/skia/+/e5e79840ef38ab1d3f03abcf1b2df66fb9940018

[Stephen White, 2016-03-21 16:48:02]

Description was changed from

==========
Change signatures of filter bounds methods to return a rect.

Change filterBounds(), onFilterBounds() and onFilterNodeBounds() to
return the destination rectangle. There was no code path that could
return false, and returning rects by value is ok now.

BUG=skia:
==========

to

==========
Change signatures of filter bounds methods to return a rect.

Change filterBounds(), onFilterBounds() and onFilterNodeBounds() to
return the destination rectangle. There was no code path that could
return false, and returning rects by value is ok now.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Stephen White, 2016-03-21 17:00:24]

Description was changed from

==========
Change signatures of filter bounds methods to return a rect.

Change filterBounds(), onFilterBounds() and onFilterNodeBounds() to
return the destination rectangle. There was no code path that could
return false, and returning rects by value is ok now.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Change signatures of filter bounds methods to return a rect.

Change filterBounds(), onFilterBounds() and onFilterNodeBounds() to
return the destination rectangle. There was no code path that could
return false, and returning rects by value is ok now.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Stephen White, 2016-03-21 17:00:24]

senorblanco@chromium.org changed reviewers:
+ reed@google.com

[Stephen White, 2016-03-21 17:44:15]

Description was changed from

==========
Change signatures of filter bounds methods to return a rect.

Change filterBounds(), onFilterBounds() and onFilterNodeBounds() to
return the destination rectangle. There was no code path that could
return false, and returning rects by value is ok now.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Change signatures of filter bounds methods to return a rect.

Change filterBounds(), onFilterBounds() and onFilterNodeBounds() to
return the destination rectangle. There was no code path that could
return false, and returning rects by value is ok now.

BUG=skia:5094
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Stephen White, 2016-03-21 17:44:32]

Description was changed from

==========
Change signatures of filter bounds methods to return a rect.

Change filterBounds(), onFilterBounds() and onFilterNodeBounds() to
return the destination rectangle. There was no code path that could
return false, and returning rects by value is ok now.

BUG=skia:5094
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Change signatures of filter bounds methods to return a rect.

Change filterBounds(), onFilterBounds() and onFilterNodeBounds() and
computeFastBounds() to
return the destination rectangle. There was no code path that could
return false, and returning rects by value is ok now.

BUG=skia:5094
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Stephen White, 2016-03-21 17:50:25]

reed@: PTAL. Thanks!

[Stephen White, 2016-03-21 17:50:35]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-21 17:50:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1823573003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1823573003/80001

[commit-bot: I haz the power, 2016-03-21 17:51:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-21 17:51:57]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[Stephen White, 2016-03-21 17:55:30]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-21 17:55:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1823573003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1823573003/100001

[commit-bot: I haz the power, 2016-03-21 18:06:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-21 18:06:44]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-03-21 20:20:55]

reed@google.com changed reviewers:
+ robertphillips@google.com

[reed1, 2016-03-21 20:20:56]

I think the only way we've found to actually enforce/fix deprecated callers is
to introduce a build-flag for the old api. Can you add one for this guy?

SK_SUPPORT_LEGACY_FILTERBOUNDS_RETURN or something like that.

You can then just define it for chrome (skia/config/SkUserConfig.h) but it
ensures that all of skia's call-sites are converted over.

[Stephen White, 2016-03-21 20:31:29]

On 2016/03/21 20:20:56, reed1 wrote:
> I think the only way we've found to actually enforce/fix deprecated callers is
> to introduce a build-flag for the old api. Can you add one for this guy?
> 
> SK_SUPPORT_LEGACY_FILTERBOUNDS_RETURN or something like that.
> 
> You can then just define it for chrome (skia/config/SkUserConfig.h) but it
> ensures that all of skia's call-sites are converted over.

Done. New patch up.

[Stephen White, 2016-03-21 20:32:32]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-21 20:32:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1823573003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1823573003/120001

[reed1, 2016-03-21 20:44:32]

lgtm

https://codereview.chromium.org/1823573003/diff/120001/include/core/SkImageFi...
File include/core/SkImageFilter.h (right):

https://codereview.chromium.org/1823573003/diff/120001/include/core/SkImageFi...
include/core/SkImageFilter.h:255: virtual SkRect computeFastBounds(const
SkRect&) const;
hope nobody in chrome/blink called this

[Stephen White, 2016-03-21 20:47:03]

https://codereview.chromium.org/1823573003/diff/120001/include/core/SkImageFi...
File include/core/SkImageFilter.h (right):

https://codereview.chromium.org/1823573003/diff/120001/include/core/SkImageFi...
include/core/SkImageFilter.h:255: virtual SkRect computeFastBounds(const
SkRect&) const;
On 2016/03/21 20:44:32, reed1 wrote:
> hope nobody in chrome/blink called this

Nope. I git grepped, and built Chrome to be sure. :)

[commit-bot: I haz the power, 2016-03-21 20:47:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-21 20:47:51]

Dry run: This issue passed the CQ dry run.

[Stephen White, 2016-03-21 21:50:45]

The CQ bit was checked by senorblanco@chromium.org

[commit-bot: I haz the power, 2016-03-21 21:50:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1823573003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1823573003/120001

[commit-bot: I haz the power, 2016-03-21 21:52:14]

Description was changed from

==========
Change signatures of filter bounds methods to return a rect.

Change filterBounds(), onFilterBounds() and onFilterNodeBounds() and
computeFastBounds() to
return the destination rectangle. There was no code path that could
return false, and returning rects by value is ok now.

BUG=skia:5094
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Change signatures of filter bounds methods to return a rect.

Change filterBounds(), onFilterBounds() and onFilterNodeBounds() and
computeFastBounds() to
return the destination rectangle. There was no code path that could
return false, and returning rects by value is ok now.

BUG=skia:5094
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/e5e79840ef38ab1d3f03abcf1b2df66fb9940018
==========

[commit-bot: I haz the power, 2016-03-21 21:52:15]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/e5e79840ef38ab1d3f03abcf1b2df66fb9940018