include/effects/SkMorphologyImageFilter.h - Issue 1823573003: Change signatures of filter bounds methods to return a rect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/effects/SkMorphologyImageFilter.h

Issue 1823573003: Change signatures of filter bounds methods to return a rect. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Hide legacy API behind #ifdef; switch callers to new API Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/effects/SkMorphologyImageFilter.h

diff --git a/include/effects/SkMorphologyImageFilter.h b/include/effects/SkMorphologyImageFilter.h

index 62e6f532dab96d8eb9619f52ec00f3bcaf77565a..f4f12605df456486ef45e2c39d21b78d1dac7bd1 100644

--- a/include/effects/SkMorphologyImageFilter.h

+++ b/include/effects/SkMorphologyImageFilter.h

@@ -15,9 +15,8 @@

class SK_API SkMorphologyImageFilter : public SkImageFilter {

public:

- void computeFastBounds(const SkRect& src, SkRect* dst) const override;

- void onFilterNodeBounds(const SkIRect& src, const SkMatrix& ctm,

- SkIRect* dst, MapDirection) const override;

+ SkRect computeFastBounds(const SkRect& src) const override;

+ SkIRect onFilterNodeBounds(const SkIRect& src, const SkMatrix&, MapDirection) const override;

/**

* All morphology procs have the same signature: src is the source buffer, dst the