Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 182333004: Revert 253521 "Introduce telemetry.web_components and a simple c..." (Closed)

Created:
6 years, 10 months ago by achuithb
Modified:
6 years, 10 months ago
Reviewers:
nduca
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 253521 "Introduce telemetry.web_components and a simple c..." > Introduce telemetry.web_components and a simple component-based Results object > > The main result of this patch is that > cd $TELEMETRY && python -m telemetry.web_components.results_viewer > > will produce an HTML file that has the same standalone-and-emailable properties as telemetry's existing HTML results object, but that is built out of tvcm components, trace-viewer's component model. Followup patches will expand out results_viewer.js with features to actually be a viable replacement for Telemetry's existing results.html. > > Importantly, with this checkin, telemetry's existing ./run_tests will also run any javascript unittests and the presubmit will lint the same js and css files. > > > BUG=340096 > > Review URL: https://codereview.chromium.org/169283004 TBR=nduca@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253611

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -335 lines) Patch
M trunk/src/tools/telemetry/PRESUBMIT.py View 1 chunk +0 lines, -6 lines 0 comments Download
D trunk/src/tools/telemetry/run_web_components_dev_server View 1 chunk +0 lines, -23 lines 0 comments Download
D trunk/src/tools/telemetry/telemetry/web_components/__init__.py View 1 chunk +0 lines, -12 lines 0 comments Download
D trunk/src/tools/telemetry/telemetry/web_components/dev_server.py View 1 chunk +0 lines, -23 lines 0 comments Download
D trunk/src/tools/telemetry/telemetry/web_components/results_viewer.js View 1 chunk +0 lines, -39 lines 0 comments Download
D trunk/src/tools/telemetry/telemetry/web_components/results_viewer.py View 1 chunk +0 lines, -30 lines 0 comments Download
D trunk/src/tools/telemetry/telemetry/web_components/results_viewer_unittest.js View 1 chunk +0 lines, -16 lines 0 comments Download
D trunk/src/tools/telemetry/telemetry/web_components/tvcm_stub.py View 1 chunk +0 lines, -10 lines 0 comments Download
D trunk/src/tools/telemetry/telemetry/web_components/viewer.py View 1 chunk +0 lines, -63 lines 0 comments Download
D trunk/src/tools/telemetry/telemetry/web_components/viewer_bootstrap.js View 1 chunk +0 lines, -18 lines 0 comments Download
D trunk/src/tools/telemetry/telemetry/web_components/viewer_unittest.py View 1 chunk +0 lines, -25 lines 0 comments Download
D trunk/src/tools/telemetry/telemetry/web_components/viewer_unittest_data.js View 1 chunk +0 lines, -34 lines 0 comments Download
D trunk/src/tools/telemetry/telemetry/web_components/web_components_project.py View 1 chunk +0 lines, -21 lines 0 comments Download
D trunk/src/tools/telemetry/telemetry/web_components/web_components_unittest.py View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
achuithb
6 years, 10 months ago (2014-02-26 22:45:04 UTC) #1
achuithb
6 years, 10 months ago (2014-02-26 22:45:11 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r253611 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698