Introduce telemetry.web_components and a simple component-based Results object

Introduce telemetry.web_components and a simple component-based Results object

The main result of this patch is that
  cd $TELEMETRY && python -m telemetry.web_components.results_viewer

will produce an HTML file that has the same standalone-and-emailable properties as telemetry's existing HTML results object, but that is built out of tvcm components, trace-viewer's component model. Followup patches will expand out results_viewer.js with features to actually be a viable replacement for Telemetry's existing results.html.

Importantly, with this checkin, telemetry's existing  ./run_tests will also run any javascript unittests and the presubmit will lint the same js and css files.


BUG=340096
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253521

[nduca, 2014-02-18 09:46:00]

ptal

[tonyg, 2014-02-19 16:44:32]

This is awesome! All my comments are mere style nits. LMK when this is ready and
I'll stamp.

Also, Dave might want to provide a second set of eyes as he usually he good
insight on these types of patches.

https://codereview.chromium.org/169283004/diff/30001/DEPS
File DEPS (right):

https://codereview.chromium.org/169283004/diff/30001/DEPS#newcode89
DEPS:89: (Var("googlecode_url") % "trace-viewer") + "/trunk@1158",
Can we land this ahead of the rest of this patch? It is always nice to separate
moving pieces.

https://codereview.chromium.org/169283004/diff/30001/tools/telemetry/run_comp...
File tools/telemetry/run_components_dev_server (right):

https://codereview.chromium.org/169283004/diff/30001/tools/telemetry/run_comp...
tools/telemetry/run_components_dev_server:2: # Copyright (c) 2012 The Chromium
Authors. All rights reserved.
2014

https://codereview.chromium.org/169283004/diff/30001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/components/__init__.py (right):

https://codereview.chromium.org/169283004/diff/30001/tools/telemetry/telemetr...
tools/telemetry/telemetry/components/__init__.py:1: # Copyright (c) 2014 The
Chromium Authors. All rights reserved.
Thinking aloud: should we name this directory web_components, html_components,
result_components or something to indicate more specifically what type of
component we are talking about. Without context, the simple term "components"
could mean anything.

https://codereview.chromium.org/169283004/diff/30001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/components/components_project.py (right):

https://codereview.chromium.org/169283004/diff/30001/tools/telemetry/telemetr...
tools/telemetry/telemetry/components/components_project.py:13: '..', '..'))
Don't we have a util method that helps with this?

https://codereview.chromium.org/169283004/diff/30001/tools/telemetry/telemetr...
tools/telemetry/telemetry/components/components_project.py:18: 'third_party',
'trace-viewer'))
and this

https://codereview.chromium.org/169283004/diff/30001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/components/components_unittest.py (right):

https://codereview.chromium.org/169283004/diff/30001/tools/telemetry/telemetr...
tools/telemetry/telemetry/components/components_unittest.py:11:
project.telemetry_path)
Should we consider an assertion that we found at least one unittest?

https://codereview.chromium.org/169283004/diff/30001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/components/dev_server.py (right):

https://codereview.chromium.org/169283004/diff/30001/tools/telemetry/telemetr...
tools/telemetry/telemetry/components/dev_server.py:1: # Copyright (c) 2012 The
Chromium Authors. All rights reserved.
2014

https://codereview.chromium.org/169283004/diff/30001/tools/telemetry/telemetr...
tools/telemetry/telemetry/components/dev_server.py:18:
os.path.dirname(__file__), '..', '..'))
Another case to use util to find this path.

https://codereview.chromium.org/169283004/diff/30001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/components/results_viewer.py (right):

https://codereview.chromium.org/169283004/diff/30001/tools/telemetry/telemetr...
tools/telemetry/telemetry/components/results_viewer.py:8: class
ResultsViewer(viewer.Viewer):
Can you post a link to an results output file this generated?

https://codereview.chromium.org/169283004/diff/30001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/components/results_viewer_unittest.js (right):

https://codereview.chromium.org/169283004/diff/30001/tools/telemetry/telemetr...
tools/telemetry/telemetry/components/results_viewer_unittest.js:1: // Copyright
(c) 2013 The Chromium Authors. All rights reserved.
2014

https://codereview.chromium.org/169283004/diff/30001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/components/tvcm_stub.py (right):

https://codereview.chromium.org/169283004/diff/30001/tools/telemetry/telemetr...
tools/telemetry/telemetry/components/tvcm_stub.py:1: # Copyright (c) 2012 The
Chromium Authors. All rights reserved.
2014

https://codereview.chromium.org/169283004/diff/30001/tools/telemetry/telemetr...
tools/telemetry/telemetry/components/tvcm_stub.py:5: import sys
I think there should be some vertical space here. The style guide doesn't seem
to be explicit, but I've been doing 1 blank line before the first import and two
after the last.

https://codereview.chromium.org/169283004/diff/30001/tools/telemetry/telemetr...
tools/telemetry/telemetry/components/tvcm_stub.py:13: sys.path.append(tvcm_path)
I think we also have a util method that appends to the path.

https://codereview.chromium.org/169283004/diff/30001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/components/viewer.py (right):

https://codereview.chromium.org/169283004/diff/30001/tools/telemetry/telemetr...
tools/telemetry/telemetry/components/viewer.py:35: bootstrap_script =
generate.ExtraScript(text_content="""
Is this long enough to warrant moving to a .js file?

[slamm, 2014-02-19 17:10:51]

Acronyms are easier to read in camelCase if you treat them as words.

https://codereview.chromium.org/169283004/diff/30001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/components/results_viewer.py (right):

https://codereview.chromium.org/169283004/diff/30001/tools/telemetry/telemetr...
tools/telemetry/telemetry/components/results_viewer.py:21: def
WriteDataToFileAsJSON(self, f):
WriteDataToFileAsJSON -> WriteDataToFileAsJson

https://codereview.chromium.org/169283004/diff/30001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/components/tvcm_stub.py (right):

https://codereview.chromium.org/169283004/diff/30001/tools/telemetry/telemetr...
tools/telemetry/telemetry/components/tvcm_stub.py:6: def _SetupTVCMPath():
_SetupTVCMPath -> _SetupTvcmPath

https://codereview.chromium.org/169283004/diff/30001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/components/viewer.py (right):

https://codereview.chromium.org/169283004/diff/30001/tools/telemetry/telemetr...
tools/telemetry/telemetry/components/viewer.py:17: WriteDataToFileAsJSON. The
data written here is passed to the
WriteDataToFileAsJson

https://codereview.chromium.org/169283004/diff/30001/tools/telemetry/telemetr...
tools/telemetry/telemetry/components/viewer.py:27: def
WriteDataToFileAsJSON(self, f):
WriteDataToFileAsJson

[nduca, 2014-02-20 06:35:06]

Thanks all. All feedback applied, thanks much. Ready to land when y'all are
happy. The deps roll has landed already.

The following python snippet:
  x = ResultsViewer({'hello': 'world', 'nice': ['to', 'see', 'you']})
  x.WriteViewerToFile(sys.stdout)

Produces this file:
  https://dl.dropboxusercontent.com/u/58819336/results_viewer_example.html

Which is roughly like:
  <style> ... all css required for results_view.js </script>
  ... any html snippets required by results_view.js...
  <script> ... all js required for results_view.js </script>
Followed by:
  <script id=data type="not-javascript>
   {'hello': 'world', 'nice': ['to', 'see', 'you']
   </script>
  <script>
      var el = new ResultsViewer();
      el.dataToView = JSON.loads(document.querySelector('#data').textContent));
      document.body.appendChild(el);
   </script>

You can also
 ./run_web_componetns_dev_server

Then go to
http://localhost:8014/tvcm/tests.html

The testBasic will be shown, including the html produced by the unit test.
Clicking that will give a link to the unit test for the same class where you can
do more-traditional edit-reload style development from the comfort of your
browser.

[slamm, 2014-02-20 16:44:11]

lgtm

[tonyg, 2014-02-20 17:18:17]

lgtm

https://codereview.chromium.org/169283004/diff/170001/tools/telemetry/telemet...
File tools/telemetry/telemetry/web_components/results_viewer.py (right):

https://codereview.chromium.org/169283004/diff/170001/tools/telemetry/telemet...
tools/telemetry/telemetry/web_components/results_viewer.py:28: import sys
Why not at the top of the file?

[nduca, 2014-02-21 04:54:14]

The CQ bit was checked by nduca@chromium.org

[commit-bot: I haz the power, 2014-02-21 04:54:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nduca@chromium.org/169283004/230001

[commit-bot: I haz the power, 2014-02-21 06:33:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-21 06:33:58]

Retried try job too often on linux_rel for step(s) telemetry_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[nduca, 2014-02-21 23:05:34]

The CQ bit was checked by nduca@chromium.org

[commit-bot: I haz the power, 2014-02-21 23:07:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nduca@chromium.org/169283004/670002

[commit-bot: I haz the power, 2014-02-22 00:22:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-22 00:22:19]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[nduca, 2014-02-26 02:07:29]

The CQ bit was checked by nduca@chromium.org

[nduca, 2014-02-26 02:54:00]

The CQ bit was unchecked by nduca@chromium.org

[nduca, 2014-02-26 10:42:41]

The CQ bit was checked by nduca@chromium.org

[commit-bot: I haz the power, 2014-02-26 10:43:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nduca@chromium.org/169283004/970001

[commit-bot: I haz the power, 2014-02-26 10:50:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-26 10:50:08]

Try jobs failed on following builders: linux_chromium_rel

[nduca, 2014-02-26 11:42:15]

The CQ bit was checked by nduca@chromium.org

[commit-bot: I haz the power, 2014-02-26 11:44:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nduca@chromium.org/169283004/970001

[commit-bot: I haz the power, 2014-02-26 18:40:10]

Change committed as 253521

[achuithb, 2014-02-26 22:26:26]

Nat: I believe this is causing failures on cros.
http://chromegw.corp.google.com/i/chromium.fyi/builders/Chromium%20Cros64%20P...

I'd like to revert this patch. Wdyt?

https://codereview.chromium.org/169283004/diff/970001/tools/telemetry/telemet...
File tools/telemetry/telemetry/web_components/tvcm_stub.py (right):

https://codereview.chromium.org/169283004/diff/970001/tools/telemetry/telemet...
tools/telemetry/telemetry/web_components/tvcm_stub.py:10: 'third_party',
'trace-viewer', 'third_party', 'tvcm')
Should this be added to bootstrap_deps?

[achuithb, 2014-02-26 22:46:43]

Reverted here: https://codereview.chromium.org/182333004/

Sorry for the inconvenience. I think this ought to pass with adding the tvcm
path to bootstrap_deps.