Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1823293002: Update timezone and apply miscellaneous locale data fixes (Closed)

Created:
4 years, 9 months ago by jungshik at Google
Modified:
4 years, 9 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, Dan Ehrenberg
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update timezone DB and apply miscellaneous locale data fixes 1. Update the IANA tz data to 2016c What's new in 2016b and 2016c are found at http://mm.icann.org/pipermail/tz-announce/2016-March/000036.html (2016b) http://mm.icann.org/pipermail/tz-announce/2016-March/000037.html (2016c) 2. Locale data fixes - en-AU date format fix from the upstream - ar and fa: Prepend 'percent sign' with RTL mark (U+200F). From Android. - tr: Use ₺ (U+20BA; Turkish Lira Sign) instead of 'TL'. This is to revert a locale patch picked up from Google's internal build of ICU. (Android also uses U+20BA). In addition, icudtl.dat (the prebuilt ICU data file for platforms other than Android is moved out of source/data/in to common/. This way, the data build steps for non-Android and Android can be unified and a bit more streamlined. icu.gyp and BUILD.gn are updated accordingly as well as README.chromium. BUG=598000 TEST=See bug comment 0 and comment 1 R=mark@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/3edd83a9c607c7dc0c0fd34d68057da5c4d0f471

Patch Set 1 #

Patch Set 2 : tz db 2016c #

Patch Set 3 : put icudtl.dat in common/ #

Patch Set 4 : fix a typo in README.chromium #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1185 lines, -1141 lines) Patch
M BUILD.gn View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M README.chromium View 1 2 3 8 chunks +40 lines, -40 lines 0 comments Download
M android/icudtl.dat View 1 2 3 Binary file 0 comments Download
A + common/icudtl.dat View 1 2 3 Binary file 0 comments Download
M icu.gyp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A patches/locale_extra.patch View 2 3 1 chunk +59 lines, -0 lines 0 comments Download
M patches/locale_google.patch View 2 3 1 chunk +0 lines, -19 lines 0 comments Download
M patches/remove_si.patch View 1 2 3 1 chunk +0 lines, -37 lines 0 comments Download
M scripts/copy_data.sh View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M source/data/curr/tr.txt View 2 3 1 chunk +6 lines, -1 line 0 comments Download
D source/data/in/icudtl.dat View 1 2 3 Binary file 0 comments Download
M source/data/locales/ar.txt View 2 3 1 chunk +1 line, -1 line 0 comments Download
M source/data/locales/en_AU.txt View 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M source/data/locales/fa.txt View 2 3 1 chunk +1 line, -1 line 0 comments Download
M source/data/misc/metaZones.txt View 1 2 3 6 chunks +24 lines, -10 lines 0 comments Download
M source/data/misc/timezoneTypes.txt View 2 3 4 chunks +4 lines, -1 line 0 comments Download
M source/data/misc/windowsZones.txt View 2 3 6 chunks +5 lines, -5 lines 0 comments Download
M source/data/misc/zoneinfo64.txt View 1 2 3 114 chunks +1036 lines, -1017 lines 0 comments Download
M windows/icudt.dll View 1 2 3 Binary file 0 comments Download

Messages

Total messages: 10 (7 generated)
jungshik at Google
Mark, can you take a look? ( icudtl.dat location change and related doc/build file changes). ...
4 years, 9 months ago (2016-03-25 20:36:49 UTC) #4
Mark Mentovai
I think Chile is making a mistake, but LGTM.
4 years, 9 months ago (2016-03-25 20:41:45 UTC) #5
jungshik at Google
4 years, 9 months ago (2016-03-25 23:34:00 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:40001) manually as
3edd83a9c607c7dc0c0fd34d68057da5c4d0f471 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698