Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: README.chromium

Issue 1823293002: Update timezone and apply miscellaneous locale data fixes (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master
Patch Set: fix a typo in README.chromium Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | android/icudtl.dat » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: README.chromium
diff --git a/README.chromium b/README.chromium
index 539d6e86003052f2e8d130e835dea2e60de19efe..7612cbb71c9c8476a73e100d9bbc8ed3d3212ecb 100644
--- a/README.chromium
+++ b/README.chromium
@@ -4,11 +4,6 @@ Version: 56.1
License: MIT
Security Critical: yes
-***NOTE***
-ICU is being updated to 56.1 pending one last adjustment on the Chromium-side.
-If you have an urgent fix to apply to ICU 54.1 used for branches,
-file a bug and contact jshin@chromium.org.
-
Description:
This directory contains the source code of ICU 56.1 for C/C++.
@@ -55,53 +50,50 @@ Pre-built data files are generated and checked in with the following steps
e. Run
${CHROME_ICU_TREE_TOP}/scripts/make_data.sh
- This will make icudt${version}l.dat and icudt${version}l_dat.S
+ This makes icudt${version}l.dat and icudt${version}l_dat.S
- f. Run
- ${CHROME_ICU_TREE_TOP}/scripts/clean_up_data_source.sh
- This will erase the result of step d (trim_data.sh).
-
- g. Run
+ f. Run
${CHROME_ICU_TREE_TOP}/scripts/copy_data.sh
- This will revert the changes made in source/data by trim_data.sh.
- It will also copy the ICU data file for non-Android platform
+ This copies the ICU data file for non-Android platform
and the corresponding assembly source files for Linux and Mac to
- the following places. Check them in.
-
- source/data/in/icudtl.dat
- source/{linux,mac}/icudtl_dat.S
-
- h. Whenever data is updated (e.g timezone update), follow d ~ g as long
- as the ICU build directory used in a ~ c is kept.
-
-2. icu data files for Android
+ the following places.
- a. Follow a ~ d for non-Android platforms
- b. Run
+ common/icudtl.dat
+ {linux,mac}/icudtl_dat.S
+ g. Run
${CHROME_ICU_TREE_TOP}/android/patch_locale.sh
- On top of trim_data.sh, further cut the data entries for Android.
+ On top of trim_data.sh (step d), further cuts the data entries for Android.
- c. Run
+ h. Run
${CHROME_ICU_TREE_TOP}/scripts/make_data.sh
- d. Run
+ This makes icudt${version}l.dat and icudt${version}l_dat.S for Android.
+
+ i. Run
${CHROME_ICU_TREE_TOP}/scripts/copy_data_android.sh
- and check in the following files.
+ This copies icu data files for Android to the following locations:
android/icudtl.dat
android/icudtl_dat.S
- e. Run
+ j. Run
${CHROME_ICU_TREE_TOP}/scripts/clean_up_data_source.sh
- This will erase the result of trim_data.sh and patch_locale.sh
+ This reverts the result of trim_data.sh and patch_locale.sh and
+ make the tree ready for committing updated ICU data files for
+ non-Android and Android platforms.
-3. icu data dll for Windows (non-default build option)
+ k. Whenever data is updated (e.g timezone update), follow d ~ j as long
+ as the ICU build directory used in a ~ c is kept. Besides, icudt.dll for
+ Windows has to be udpated following the procedure described below.
+
+
+2. icu data dll for Windows (non-default build option)
Follow these steps to build windows/icudt.dll. By default, we set
icu_use_icu_data_flag to 1 and don't use this file.
@@ -111,7 +103,7 @@ Pre-built data files are generated and checked in with the following steps
$ svn export --native-eol LF http://source.icu-project.org/repos/icu/icu/tags/release-56-1 ${SEPARATE_ICU_ROOT}/icu56
- b. copy ${CHROME_ICU_ROOT}/source/data/in/icudtl.dat to
+ b. copy ${CHROME_ICU_ROOT}/common/icudtl.dat to
${SEPARATE_ICU_ROOT}/source/data/in/icudt56l.dat
c. copy ${CHROME_ICU_ROOT}/source/data/makedata.mak to
${SEPARATE_ICU_ROOT}/source/data/makedata.mak
@@ -122,7 +114,7 @@ Pre-built data files are generated and checked in with the following steps
f. Copy that icudt56.dll to ${CHROME_ICU_ROOT}/windows/icudt.dll
and check that in.
-4. Note on the locale data customization
+3. Note on the locale data customization
- scripts/trim_data.sh
a. Trim the locale data for Chrome's UI langauges :
@@ -201,7 +193,7 @@ D. Local Modifications
- patches/locale_google.patch:
* Google's internal ICU locale changes
* Simpler region names for Hong Kong and Macau in all locales
- * Currency signs in ru, uk and tr locales
+ * Currency signs in ru and uk locales (do not include 'tr' locale changes)
* AM/PM, midnight, noon formatting for a few Indian locales
* Timezone name changes in Korean and Chinese locales
@@ -253,9 +245,9 @@ D. Local Modifications
windowsZones.txt
zoneinfo64.txt
- As of Feb 8, 2016, the latest version is 2016a and the above files
+ As of March 24, 2016, the latest version is 2016c and the above files
are available at
- http://source.icu-project.org/repos/icu/data/trunk/tzdata/icunew/2016a/44/
+ http://source.icu-project.org/repos/icu/data/trunk/tzdata/icunew/2016c/44/
5. Build-related changes
@@ -283,7 +275,7 @@ D. Local Modifications
7. Fix 'bad cast' found in Transliterator with a cfi build
- patches/xlit_badcast.patch
- - upstream bug (fixed in the upstream. Will be in 57 release)
+ - upstream bug (fixed in the upstream. Will be in ICU 57 release)
http://bugs.icu-project.org/trac/ticket/11937
8. Add back UTF-32 converters temporarily even when
@@ -296,15 +288,23 @@ D. Local Modifications
9. Fix a UText bug found in uregex_open fuzzer.
- patches/utext.patch
- - upstream bug (fixed in trunk in Jan, 2016. Will be in 57 release)
+ - upstream bug (fixed in trunk in Jan, 2016. Will be in ICU 57 release)
http://bugs.icu-project.org/trac/ticket/12130
10. Fix a bug in regex compiler.
- patches/regexcmp.patch
- - upstream bug (fixed in the upstream. Will be in 57 release)
+ - upstream bug (fixed in the upstream. Will be in ICU 57 release)
http://bugs.icu-project.org/trac/ticket/12138
11. Remove an unnecessary static initializer
- patches/remove_si.patch
- - upstream bug
+ - upstream bug (fixed in trunk. Will be in ICU 57 release)
http://bugs.icu-project.org/trac/ticket/12408
+
+12. Cherry pick locale data fixes from the upstream and Android
+ - patches/locale_extra.patch
+ - upstream bugs
+ http://unicode.org/cldr/trac/ticket/9045 (en-AU date format)
+ http://unicode.org/cldr/trac/ticket/7969 (percent sign in ar and fa)
+ - Android patch for the 2nd bug
+ https://android.googlesource.com/platform/external/icu/+/56b2b8b
« no previous file with comments | « BUILD.gn ('k') | android/icudtl.dat » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698