third_party/WebKit/Source/platform/graphics/Image.cpp - Issue 1823133002: Use sk_sp-based picture recording APIs in Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/Image.cpp

Issue 1823133002: Use sk_sp-based picture recording APIs in Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/Image.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/Image.cpp b/third_party/WebKit/Source/platform/graphics/Image.cpp

index fb9a02496824117ca9688aeb6ba49524a7088beb..0feceb60d3bcbbbc5a4b4b201b3b1dc3cb76d0b6 100644

--- a/third_party/WebKit/Source/platform/graphics/Image.cpp

+++ b/third_party/WebKit/Source/platform/graphics/Image.cpp

@@ -199,10 +199,9 @@ sk_sp<SkShader> createPatternShader(const SkImage* image, const SkMatrix& shader

SkPictureRecorder recorder;

SkCanvas* canvas = recorder.beginRecording(tileRect);

canvas->drawImage(image, 0, 0, &paint);

- sk_sp<SkPicture> picture(recorder.endRecordingAsPicture());

- return SkShader::MakePictureShader(

- std::move(picture), SkShader::kRepeat_TileMode, SkShader::kRepeat_TileMode, &shaderMatrix, nullptr);

+ return SkShader::MakePictureShader(recorder.finishRecordingAsPicture(),

+ SkShader::kRepeat_TileMode, SkShader::kRepeat_TileMode, &shaderMatrix, nullptr);

}

} // anonymous namespace