third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp - Issue 1823133002: Use sk_sp-based picture recording APIs in Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp

Issue 1823133002: Use sk_sp-based picture recording APIs in Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp b/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp

index b6535bbb72a563b31c4a8484e8f097c1f64cadba..a96bbe970df825107d920fae4429c626a1350e84 100644

--- a/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp

+++ b/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp

@@ -308,7 +308,7 @@ PassRefPtr<SkPicture> GraphicsContext::endRecording()

if (contextDisabled())

return nullptr;

- RefPtr<SkPicture> picture = adoptRef(m_pictureRecorder.endRecordingAsPicture());

+ RefPtr<SkPicture> picture = fromSkSp(m_pictureRecorder.finishRecordingAsPicture());

m_canvas = nullptr;

ASSERT(picture);

return picture.release();