Use sk_sp-based picture recording APIs in Blink

android_webview/browser/browser_view_renderer.cc

Index: android_webview/browser/browser_view_renderer.cc
diff --git a/android_webview/browser/browser_view_renderer.cc b/android_webview/browser/browser_view_renderer.cc
index cf6b4b4f6fc9262776adad9e860cc7dbf020bb83..ce7f49b11ab8aed4e2569fc72e004e2b5a6789fd 100644
--- a/android_webview/browser/browser_view_renderer.cc
+++ b/android_webview/browser/browser_view_renderer.cc
@@ -329,7 +329,7 @@ skia::RefPtr<SkPicture> BrowserViewRenderer::CapturePicture(int width,
   if (width <= 0 || height <= 0) {
     SkPictureRecorder emptyRecorder;
     emptyRecorder.beginRecording(0, 0);
-    return skia::AdoptRef(emptyRecorder.endRecording());
+    return skia::AdoptRef(emptyRecorder.finishRecordingAsPicture());

[Stephen White, 2016/03/24 19:05:57]

Out of curiosity, are there plans to place skia::RefPtr<> with something else at
some point (sk_sp<>)? Or are we going to keep it?

[f(malita), 2016/03/24 19:17:10]

Now that we have sk_sp I think it makes perfect sense to retire skia::RefPtr: no
reason to maintain a Skia-specific smart ptr when Skia provides one with
equivalent semantics.

(the process has already started - as we update Chromium to the new APIs, we're
also pushing sk_sp as replacement, e.g.
https://codereview.chromium.org/1819683002)

[Stephen White, 2016/03/24 19:42:54]

In that case, should this function be returning an sk_sp<SkPicture>?

[f(malita), 2016/03/24 20:22:41]

It should, but I would rather not pull on this particular thread atm because a)
sk_sp is not assignable to skia::RefPtr (we should prolly add that to ease the
migration), and b) I'm hesitant to touch webview interfaces since I don't have a
good way to test locally (and am suspicious of bot coverage).

   }
 
   SkPictureRecorder recorder;
@@ -344,7 +344,7 @@ skia::RefPtr<SkPicture> BrowserViewRenderer::CapturePicture(int width,
     compositor_->DidChangeRootLayerScrollOffset(
         gfx::ScrollOffset(scroll_offset_dip_));
   }
-  return skia::AdoptRef(recorder.endRecording());
+  return skia::AdoptRef(recorder.finishRecordingAsPicture());
 }
 
 void BrowserViewRenderer::EnableOnNewPicture(bool enabled) {