Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5225)

Unified Diff: chrome/chrome_tests_unit.gypi

Issue 182313002: Include sync.pb.h in sync_data.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Apply CR feedback. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_tests_unit.gypi
diff --git a/chrome/chrome_tests_unit.gypi b/chrome/chrome_tests_unit.gypi
index b54530149d21223261d6e92a2ff65e607a373926..d80c0c1be7ebab31cc9bb41ab82d7e53fff48c68 100644
--- a/chrome/chrome_tests_unit.gypi
+++ b/chrome/chrome_tests_unit.gypi
@@ -12,6 +12,7 @@
# NOTE: New dependencies should generally be added in the OS!="ios"
# dependencies block below, rather than here.
'browser',
+ 'browser_real',
maniscalco 2014/03/07 23:44:39 Needed because ui_test_utils.h includes history_se
Nico 2014/03/08 00:45:57 I think browser_real is supposed to be an implemen
maniscalco 2014/03/08 01:27:00 You're right, this dependency on browser_real is r
'chrome_resources.gyp:chrome_resources',
'chrome_resources.gyp:chrome_strings',
'chrome_resources.gyp:theme_resources',
@@ -34,6 +35,7 @@
'../ui/message_center/message_center.gyp:message_center_test_support',
],
'export_dependent_settings': [
+ 'browser_real',
maniscalco 2014/03/07 23:44:39 history_service.h (part of browser_real) includes
maniscalco 2014/03/08 01:27:00 Correction: we need to export browser's settings a
'../base/base.gyp:test_support_base',
'../content/content_shell_and_tests.gyp:test_support_content',
],

Powered by Google App Engine
This is Rietveld 408576698