components/password_manager.gypi - Issue 182313002: Include sync.pb.h in sync_data.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager.gypi

Issue 182313002: Include sync.pb.h in sync_data.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Apply CR feedback. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/password_manager.gypi

diff --git a/components/password_manager.gypi b/components/password_manager.gypi

index 2c7debdf14812154d4914307f0c879ce13ccc4e6..c57858082744558481d6a443ebb23ec95e4ba131 100644

--- a/components/password_manager.gypi

+++ b/components/password_manager.gypi

@@ -14,8 +14,12 @@

'../base/base.gyp:base',

'../net/net.gyp:net',

'../sql/sql.gyp:sql',

+ '../sync/sync.gyp:sync',

maniscalco 2014/03/07 23:44:39 Needed because password_store.h includes sync/api/

'../url/url.gyp:url_lib',

+ 'export_dependent_settings': [

+ '../sync/sync.gyp:sync',

+ ],

'include_dirs': [

'..',

@@ -92,6 +96,7 @@

'type': 'static_library',

'dependencies': [

'autofill_core_common',

+ 'password_manager_core_browser',

'../base/base.gyp:base',

'../testing/gmock.gyp:gmock',

'../testing/gtest.gyp:gtest',