VM: Intrinsify double arithmetic operations with a smi rhs.

VM: Intrinsify double arithmetic operations with a smi rhs.

This avoids calling the native C++ implementation from
unoptimized and precompiled code when the rhs of a double +, -, * or /
is a smi.

BUG=
R=srdjan@google.com

Committed: https://github.com/dart-lang/sdk/commit/dae61fee7a350115843710054091d9fab6966853

[Florian Schneider, 2016-03-22 15:45:34]

fschneider@google.com changed reviewers:
+ srdjan@google.com

[srdjan, 2016-03-22 16:43:13]

lgtm

[Florian Schneider, 2016-03-22 16:56:54]

Description was changed from

==========
VM: Intrinsify double arithmetic operations with a smi rhs.

This avoids calling the native C++ implementation from
unoptimized and precompiled code when the rhs of a double +, -, * or /
is a smi.

BUG=
==========

to

==========
VM: Intrinsify double arithmetic operations with a smi rhs.

This avoids calling the native C++ implementation from
unoptimized and precompiled code when the rhs of a double +, -, * or /
is a smi.

BUG=
R=srdjan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/dae61fee7a350115843710054091d9fab6966853
==========

[Florian Schneider, 2016-03-22 16:56:55]

Committed patchset #1 (id:1) manually as
dae61fee7a350115843710054091d9fab6966853 (presubmit successful).

[zra, 2016-03-22 17:12:21]

zra@google.com changed reviewers:
+ zra@google.com

[zra, 2016-03-22 17:12:22]

DBC

https://codereview.chromium.org/1823123002/diff/1/runtime/vm/intrinsifier_arm...
File runtime/vm/intrinsifier_arm64.cc (right):

https://codereview.chromium.org/1823123002/diff/1/runtime/vm/intrinsifier_arm...
runtime/vm/intrinsifier_arm64.cc:1411: __ b(&double_op);  // Then do the
comparison.
comparison -> operation. For other platforms as well.

https://codereview.chromium.org/1823123002/diff/1/runtime/vm/intrinsifier_mip...
File runtime/vm/intrinsifier_mips.cc (right):

https://codereview.chromium.org/1823123002/diff/1/runtime/vm/intrinsifier_mip...
runtime/vm/intrinsifier_mips.cc:1414: __ b(&double_op);
It looks like you can use the delay slot here.

[Florian Schneider, 2016-03-25 16:09:47]

Thanks. https://codereview.chromium.org/1835583002

https://codereview.chromium.org/1823123002/diff/1/runtime/vm/intrinsifier_arm...
File runtime/vm/intrinsifier_arm64.cc (right):

https://codereview.chromium.org/1823123002/diff/1/runtime/vm/intrinsifier_arm...
runtime/vm/intrinsifier_arm64.cc:1411: __ b(&double_op);  // Then do the
comparison.
On 2016/03/22 17:12:21, zra wrote:
> comparison -> operation. For other platforms as well.

Done.

https://codereview.chromium.org/1823123002/diff/1/runtime/vm/intrinsifier_mip...
File runtime/vm/intrinsifier_mips.cc (right):

https://codereview.chromium.org/1823123002/diff/1/runtime/vm/intrinsifier_mip...
runtime/vm/intrinsifier_mips.cc:1414: __ b(&double_op);
On 2016/03/22 17:12:21, zra wrote:
> It looks like you can use the delay slot here.

Done. Here and for comparisons.