Null check font family name in createFontFamilyValue

Null check font family name in createFontFamilyValue

Font family names can be null by simply providing an empty <string>.
In this case avoid the caching and return an empty CSSFontFamilyValue.

Added computed-style-empty-font-family.html to test the behavior.

Behavior matches Firefox.

BUG=596015
Committed: https://crrev.com/53e4c917c7ad7892bd763c2b1e66c53c5df50a57
Cr-Commit-Position: refs/heads/master@{#382745}

[rwlbuis, 2016-03-22 18:11:34]

Description was changed from

==========
596015 WIP

BUG=
==========

to

==========
Null check font family in computed style

Font family names can be made null by simply providing an empty <string>. 

BUG=596015
==========

[rwlbuis, 2016-03-22 18:12:58]

Description was changed from

==========
Null check font family in computed style

Font family names can be made null by simply providing an empty <string>. 

BUG=596015
==========

to

==========
Null check font family in computed style

Font family names can be made null by simply providing an empty <string>.
In this case avoid the caching and simply return an empty CSSFontFamilyValue.

Added to test this.

Behavior matches Firefox.

BUG=596015
==========

[rwlbuis, 2016-03-22 18:13:40]

Description was changed from

==========
Null check font family in computed style

Font family names can be made null by simply providing an empty <string>.
In this case avoid the caching and simply return an empty CSSFontFamilyValue.

Added to test this.

Behavior matches Firefox.

BUG=596015
==========

to

==========
Null check font family in computed style

Font family names can be made null by simply providing an empty <string>.
In this case avoid the caching and simply return an empty CSSFontFamilyValue.

Added computed-style-empty-font-family.html to test this.

Behavior matches Firefox.

BUG=596015
==========

[rwlbuis, 2016-03-22 18:14:40]

Description was changed from

==========
Null check font family in computed style

Font family names can be made null by simply providing an empty <string>.
In this case avoid the caching and simply return an empty CSSFontFamilyValue.

Added computed-style-empty-font-family.html to test this.

Behavior matches Firefox.

BUG=596015
==========

to

==========
Null check font family name in createFontFamilyValue

Font family names can be made null by simply providing an empty <string>.
In this case avoid the caching and simply return an empty CSSFontFamilyValue.

Added computed-style-empty-font-family.html to test this.

Behavior matches Firefox.

BUG=596015
==========

[rwlbuis, 2016-03-22 18:15:17]

Description was changed from

==========
Null check font family name in createFontFamilyValue

Font family names can be made null by simply providing an empty <string>.
In this case avoid the caching and simply return an empty CSSFontFamilyValue.

Added computed-style-empty-font-family.html to test this.

Behavior matches Firefox.

BUG=596015
==========

to

==========
Null check font family name in createFontFamilyValue

Font family names can be made null by simply providing an empty <string>.
In this case avoid the caching and simply return an empty CSSFontFamilyValue.

Added computed-style-empty-font-family.html to the behavior.

Behavior matches Firefox.

BUG=596015
==========

[rwlbuis, 2016-03-22 18:15:44]

Description was changed from

==========
Null check font family name in createFontFamilyValue

Font family names can be made null by simply providing an empty <string>.
In this case avoid the caching and simply return an empty CSSFontFamilyValue.

Added computed-style-empty-font-family.html to the behavior.

Behavior matches Firefox.

BUG=596015
==========

to

==========
Null check font family name in createFontFamilyValue

Font family names can be made null by simply providing an empty <string>.
In this case avoid the caching and simply return an empty CSSFontFamilyValue.

Added computed-style-empty-font-family.html to test the behavior.

Behavior matches Firefox.

BUG=596015
==========

[rwlbuis, 2016-03-22 18:33:59]

Description was changed from

==========
Null check font family name in createFontFamilyValue

Font family names can be made null by simply providing an empty <string>.
In this case avoid the caching and simply return an empty CSSFontFamilyValue.

Added computed-style-empty-font-family.html to test the behavior.

Behavior matches Firefox.

BUG=596015
==========

to

==========
Null check font family name in createFontFamilyValue

Font family names can be null by simply providing an empty <string>.
In this case avoid the caching and simply return an empty CSSFontFamilyValue.

Added computed-style-empty-font-family.html to test the behavior.

Behavior matches Firefox.

BUG=596015
==========

[rwlbuis, 2016-03-22 18:34:09]

Description was changed from

==========
Null check font family name in createFontFamilyValue

Font family names can be null by simply providing an empty <string>.
In this case avoid the caching and simply return an empty CSSFontFamilyValue.

Added computed-style-empty-font-family.html to test the behavior.

Behavior matches Firefox.

BUG=596015
==========

to

==========
Null check font family name in createFontFamilyValue

Font family names can be null by simply providing an empty <string>.
In this case avoid the caching and return an empty CSSFontFamilyValue.

Added computed-style-empty-font-family.html to test the behavior.

Behavior matches Firefox.

BUG=596015
==========

[rwlbuis, 2016-03-22 18:36:00]

rob.buis@samsung.com changed reviewers:
+ timloh@chromium.org

[rwlbuis, 2016-03-22 18:36:00]

PTAL.

[Timothy Loh, 2016-03-22 23:21:02]

On 2016/03/22 18:36:00, rwlbuis wrote:
> PTAL.

...oh, I guess that makes sense. lgtm

[rwlbuis, 2016-03-22 23:26:41]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-03-22 23:27:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1823073003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1823073003/20001

[commit-bot: I haz the power, 2016-03-23 00:35:18]

Description was changed from

==========
Null check font family name in createFontFamilyValue

Font family names can be null by simply providing an empty <string>.
In this case avoid the caching and return an empty CSSFontFamilyValue.

Added computed-style-empty-font-family.html to test the behavior.

Behavior matches Firefox.

BUG=596015
==========

to

==========
Null check font family name in createFontFamilyValue

Font family names can be null by simply providing an empty <string>.
In this case avoid the caching and return an empty CSSFontFamilyValue.

Added computed-style-empty-font-family.html to test the behavior.

Behavior matches Firefox.

BUG=596015
==========

[commit-bot: I haz the power, 2016-03-23 00:35:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-23 00:36:57]

Description was changed from

==========
Null check font family name in createFontFamilyValue

Font family names can be null by simply providing an empty <string>.
In this case avoid the caching and return an empty CSSFontFamilyValue.

Added computed-style-empty-font-family.html to test the behavior.

Behavior matches Firefox.

BUG=596015
==========

to

==========
Null check font family name in createFontFamilyValue

Font family names can be null by simply providing an empty <string>.
In this case avoid the caching and return an empty CSSFontFamilyValue.

Added computed-style-empty-font-family.html to test the behavior.

Behavior matches Firefox.

BUG=596015

Committed: https://crrev.com/53e4c917c7ad7892bd763c2b1e66c53c5df50a57
Cr-Commit-Position: refs/heads/master@{#382745}
==========

[commit-bot: I haz the power, 2016-03-23 00:36:59]

Patchset 2 (id:??) landed as
https://crrev.com/53e4c917c7ad7892bd763c2b1e66c53c5df50a57
Cr-Commit-Position: refs/heads/master@{#382745}