third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-empty-font-family.html - Issue 1823073003: Null check font family name in createFontFamilyValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-empty-font-family.html

Issue 1823073003: Null check font family name in createFontFamilyValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-empty-font-family-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-empty-font-family.html

diff --git a/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-font-family.html b/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-empty-font-family.html

similarity index 78%

copy from third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-font-family.html

copy to third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-empty-font-family.html

index 83bd9a2a8645d855d15ab2db9c102748fa90494d..3e0376e3e8df166078081a31728ab3fc3361e70e 100644

--- a/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-font-family.html

+++ b/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-empty-font-family.html

@@ -15,7 +15,7 @@ function test()

document.getElementById("exposed").textContent = text;

}

</script>

-<body onload="test()" style="font-family: monospace, 'Lucida Grande', sans-serif">

-Font attributes. The font-family should list three families:

+<body onload="test()" style="font-family: ''">

+Font attributes. The font-family should list the empty string:

</body>