Use the line box's direction in computeGlyphOverflow

Use the line box's direction in computeGlyphOverflow

Use SVGInlineTextBox::constructTextRun in order to get the direction as
determined by the BiDi algorithm rather than the what is specified on
the element. (This should also get the right override value for similar
reasons.)

BUG=596721
Committed: https://crrev.com/eb829d2e605994528ec3f6cf1edd69a3e6f3fb97
Cr-Commit-Position: refs/heads/master@{#382655}

[fs, 2016-03-22 15:00:44]

fs@opera.com changed reviewers:
+ pdr@chromium.org

[fs, 2016-03-22 15:00:45]

Most of the expectation changes are small (single pixel) in case where the
specified direction differ from the direction computed by the BiDi algo.

svg/text/combining-character-queries.html has a bigger change, but I take it
that's what you expected. (Very font-dependent, so only on Mac.)

If this goes well, I'll be uploading an other CL that moves (hides)
SVGTextMetrics::constructTextRun to where it makes more sense (IMHO.)

[pdr., 2016-03-22 19:46:38]

On 2016/03/22 at 15:00:45, fs wrote:
> Most of the expectation changes are small (single pixel) in case where the
specified direction differ from the direction computed by the BiDi algo.
> 
> svg/text/combining-character-queries.html has a bigger change, but I take it
that's what you expected. (Very font-dependent, so only on Mac.)
> 
> If this goes well, I'll be uploading an other CL that moves (hides)
SVGTextMetrics::constructTextRun to where it makes more sense (IMHO.)

Excellent analysis as usual Fredrik. +1 for hiding constructTextRun too.

With this change, I'll also have a followup for you :) (Removing the character
width/height walk in SVGTextLayoutEngine::recordTextFragment)

[pdr., 2016-03-22 19:47:44]

The CQ bit was checked by pdr@chromium.org

[pdr., 2016-03-22 19:47:45]

lgtm

[commit-bot: I haz the power, 2016-03-22 19:48:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1823073002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1823073002/20001

[commit-bot: I haz the power, 2016-03-22 19:54:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-22 19:55:39]

Description was changed from

==========
Use the line box's direction in computeGlyphOverflow

Use SVGInlineTextBox::constructTextRun in order to get the direction as
determined by the BiDi algorithm rather than the what is specified on
the element. (This should also get the right override value for similar
reasons.)

BUG=596721
==========

to

==========
Use the line box's direction in computeGlyphOverflow

Use SVGInlineTextBox::constructTextRun in order to get the direction as
determined by the BiDi algorithm rather than the what is specified on
the element. (This should also get the right override value for similar
reasons.)

BUG=596721

Committed: https://crrev.com/eb829d2e605994528ec3f6cf1edd69a3e6f3fb97
Cr-Commit-Position: refs/heads/master@{#382655}
==========

[commit-bot: I haz the power, 2016-03-22 19:55:41]

Patchset 2 (id:??) landed as
https://crrev.com/eb829d2e605994528ec3f6cf1edd69a3e6f3fb97
Cr-Commit-Position: refs/heads/master@{#382655}

[fs, 2016-03-22 20:13:21]

On 2016/03/22 at 19:46:38, pdr wrote:
> With this change, I'll also have a followup for you :) (Removing the character
width/height walk in SVGTextLayoutEngine::recordTextFragment)

Bring it on! =P (it's only laundry day once a week, uhm month, or something...)