Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1823073002: Use the line box's direction in computeGlyphOverflow (Closed)

Created:
4 years, 9 months ago by fs
Modified:
4 years, 9 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the line box's direction in computeGlyphOverflow Use SVGInlineTextBox::constructTextRun in order to get the direction as determined by the BiDi algorithm rather than the what is specified on the element. (This should also get the right override value for similar reasons.) BUG=596721 Committed: https://crrev.com/eb829d2e605994528ec3f6cf1edd69a3e6f3fb97 Cr-Commit-Position: refs/heads/master@{#382655}

Patch Set 1 #

Patch Set 2 : TEs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +22 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
fs
Most of the expectation changes are small (single pixel) in case where the specified direction ...
4 years, 9 months ago (2016-03-22 15:00:45 UTC) #2
pdr.
On 2016/03/22 at 15:00:45, fs wrote: > Most of the expectation changes are small (single ...
4 years, 9 months ago (2016-03-22 19:46:38 UTC) #3
pdr.
lgtm
4 years, 9 months ago (2016-03-22 19:47:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823073002/20001
4 years, 9 months ago (2016-03-22 19:48:21 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-22 19:54:32 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/eb829d2e605994528ec3f6cf1edd69a3e6f3fb97 Cr-Commit-Position: refs/heads/master@{#382655}
4 years, 9 months ago (2016-03-22 19:55:41 UTC) #9
fs
4 years, 9 months ago (2016-03-22 20:13:21 UTC) #10
Message was sent while issue was closed.
On 2016/03/22 at 19:46:38, pdr wrote:
> With this change, I'll also have a followup for you :) (Removing the character
width/height walk in SVGTextLayoutEngine::recordTextFragment)

Bring it on! =P (it's only laundry day once a week, uhm month, or something...)

Powered by Google App Engine
This is Rietveld 408576698