third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp - Issue 1823073002: Use the line box's direction in computeGlyphOverflow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp

Issue 1823073002: Use the line box's direction in computeGlyphOverflow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: TEs Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp

index 68f4a4c01b3c5900252872c90f3b7cb25a06bf9e..895438085f75f7273e11705b6d8045c4055a4bea 100644

--- a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp

@@ -114,7 +114,7 @@ void SVGTextLayoutEngine::updateRelativePositionAdjustmentsIfNeeded(float dx, fl

static void computeGlyphOverflow(SVGInlineTextBox* textBox, SVGTextFragment& textFragment)

{

LineLayoutSVGInlineText textLineLayout = LineLayoutSVGInlineText(textBox->getLineLayoutItem());

- TextRun run = SVGTextMetrics::constructTextRun(textLineLayout, textFragment.characterOffset, textFragment.length, textLineLayout.styleRef().direction());

+ TextRun run = textBox->constructTextRun(textLineLayout.styleRef(), textFragment);

float scalingFactor = textLineLayout.scalingFactor();

ASSERT(scalingFactor);

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »