Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 1822883002: Merge "Add unicode flag to blink::ScriptRegexp, and measure incompatibility for |pattern| content a… (Closed)

Created:
4 years, 9 months ago by tkent
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Merge "Add unicode flag to blink::ScriptRegexp, and measure incompatibility for |pattern| content attribute." to M50 "u" flag might cause compatibility issues. e.g. pattern="\a" is same as "a" in BMP mode. pattern="\a" is an error in Unicode mode. pattern=".." matches to value="🐘" in BMP mode. pattern="." matches to value="🐘" in Unicode mode. BUG=535441, 595255 Review URL: https://codereview.chromium.org/1805343002 Cr-Commit-Position: refs/heads/master@{#381468} (cherry picked from commit f74fd8cda50bb8bcc0c2d5c1fc695f86c7aa581a) Committed: https://chromium.googlesource.com/chromium/src/+/83541513f79a28c0ee4130a4d1cd4c20e0f8f386

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.h View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/BaseTextInputType.cpp View 1 chunk +15 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
tkent
4 years, 9 months ago (2016-03-21 23:42:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
83541513f79a28c0ee4130a4d1cd4c20e0f8f386.

Powered by Google App Engine
This is Rietveld 408576698