Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 1805343002: Add unicode flag to blink::ScriptRegexp, and measure incompatibility for |pattern| content attribut… (Closed)

Created:
4 years, 9 months ago by tkent
Modified:
4 years, 9 months ago
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add unicode flag to blink::ScriptRegexp, and measure incompatibility for |pattern| content attribute. "u" flag might cause compatibility issues. e.g. pattern="\a" is same as "a" in BMP mode. pattern="\a" is an error in Unicode mode. pattern=".." matches to value="🐘" in BMP mode. pattern="." matches to value="🐘" in Unicode mode. BUG=535441, 595255 TBR=isherman@chromium.org Committed: https://crrev.com/f74fd8cda50bb8bcc0c2d5c1fc695f86c7aa581a Cr-Commit-Position: refs/heads/master@{#381468}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -4 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.h View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/BaseTextInputType.cpp View 1 chunk +15 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
tkent
Keishi, would you review this please?
4 years, 9 months ago (2016-03-16 08:14:47 UTC) #3
keishi
LGTM
4 years, 9 months ago (2016-03-16 11:47:25 UTC) #4
haraken
bindings/ LGTM
4 years, 9 months ago (2016-03-16 11:47:51 UTC) #5
tkent
TBRing isherman@chromium.org. histograms.xml change was made by a tool.
4 years, 9 months ago (2016-03-16 14:28:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805343002/1
4 years, 9 months ago (2016-03-16 14:28:50 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 16:27:09 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f74fd8cda50bb8bcc0c2d5c1fc695f86c7aa581a Cr-Commit-Position: refs/heads/master@{#381468}
4 years, 9 months ago (2016-03-16 16:28:04 UTC) #14
Ilya Sherman
4 years, 9 months ago (2016-03-16 22:24:24 UTC) #15
Message was sent while issue was closed.
histograms.xml lgtm

Powered by Google App Engine
This is Rietveld 408576698