Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1822813002: MD Settings: Make <settings-dialog> respond to ESC key. (Closed)

Created:
4 years, 9 months ago by dpapad
Modified:
4 years, 9 months ago
Reviewers:
dschuyler, Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Make <settings-dialog> respond to ESC key. BUG=596637 Committed: https://crrev.com/18f047382923518df79038a3a58cc7f8ecc0c712 Cr-Commit-Position: refs/heads/master@{#382423}

Patch Set 1 #

Patch Set 2 : Add test. #

Patch Set 3 : Change ESC to Esc #

Patch Set 4 : ESC to Esc again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -12 lines) Patch
M chrome/browser/resources/settings/settings_dialog.js View 1 chunk +13 lines, -1 line 0 comments Download
M chrome/test/data/webui/settings/cr_settings_browsertest.js View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/data/webui/settings/reset_page_test.js View 1 2 3 4 chunks +20 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
dpapad
4 years, 9 months ago (2016-03-21 20:55:44 UTC) #2
Dan Beam
feel free to go ahead with this, but fyi: https://github.com/PolymerElements/paper-dialog-behavior/issues/80
4 years, 9 months ago (2016-03-21 21:15:55 UTC) #4
dschuyler
lgtm
4 years, 9 months ago (2016-03-21 21:24:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1822813002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1822813002/60001
4 years, 9 months ago (2016-03-21 21:32:58 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-21 22:49:09 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 22:50:46 UTC) #11
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/18f047382923518df79038a3a58cc7f8ecc0c712
Cr-Commit-Position: refs/heads/master@{#382423}

Powered by Google App Engine
This is Rietveld 408576698