Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/settings/settings_dialog.js

Issue 1822813002: MD Settings: Make <settings-dialog> respond to ESC key. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ESC to Esc again. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/cr_settings_browsertest.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_dialog.js
diff --git a/chrome/browser/resources/settings/settings_dialog.js b/chrome/browser/resources/settings/settings_dialog.js
index da5bc81537d4b1f75be1bfbeca58e85126dae14f..888ae0d4c5cc5df61b9a4919539ac91877657e0f 100644
--- a/chrome/browser/resources/settings/settings_dialog.js
+++ b/chrome/browser/resources/settings/settings_dialog.js
@@ -10,7 +10,19 @@ Polymer({
properties: {
/** @override */
- modal: {
+ noCancelOnOutsideClick: {
+ type: Boolean,
+ value: true,
+ },
+
+ /** @override */
+ noCancelOnEscKey: {
+ type: Boolean,
+ value: false,
+ },
+
+ /** @override */
+ withBackdrop: {
type: Boolean,
value: true,
},
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/cr_settings_browsertest.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698