Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 1822793003: [DevTools] Skip pause at DOM breakpoint when breakpoints are deactivated (Closed)

Created:
4 years, 9 months ago by kozy
Modified:
4 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kinuko+watch, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Skip pause at DOM breakpoint when breakpoints are deactivated BUG=596333 R=dgozman@chromium.org Committed: https://crrev.com/6e205b97acae0b352132fe846e251c7467ce8bb4 Cr-Commit-Position: refs/heads/master@{#382403}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kozy
ptal!
4 years, 9 months ago (2016-03-21 19:33:12 UTC) #1
dgozman
lgtm
4 years, 9 months ago (2016-03-21 20:38:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1822793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1822793003/1
4 years, 9 months ago (2016-03-21 20:44:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 21:54:40 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 21:57:16 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e205b97acae0b352132fe846e251c7467ce8bb4
Cr-Commit-Position: refs/heads/master@{#382403}

Powered by Google App Engine
This is Rietveld 408576698