Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

Issue 1822793003: [DevTools] Skip pause at DOM breakpoint when breakpoints are deactivated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/v8_inspector/V8DebuggerAgentImpl.h" 5 #include "platform/v8_inspector/V8DebuggerAgentImpl.h"
6 6
7 #include "platform/inspector_protocol/String16.h" 7 #include "platform/inspector_protocol/String16.h"
8 #include "platform/inspector_protocol/Values.h" 8 #include "platform/inspector_protocol/Values.h"
9 #include "platform/v8_inspector/IgnoreExceptionsScope.h" 9 #include "platform/v8_inspector/IgnoreExceptionsScope.h"
10 #include "platform/v8_inspector/InjectedScript.h" 10 #include "platform/v8_inspector/InjectedScript.h"
(...skipping 781 matching lines...) Expand 10 before | Expand all | Expand 10 after
792 return; 792 return;
793 InjectedScript* injectedScript = m_injectedScriptManager->findInjectedScript (errorString, remoteId.get()); 793 InjectedScript* injectedScript = m_injectedScriptManager->findInjectedScript (errorString, remoteId.get());
794 if (!injectedScript) 794 if (!injectedScript)
795 return; 795 return;
796 injectedScript->getCollectionEntries(errorString, objectId, entries); 796 injectedScript->getCollectionEntries(errorString, objectId, entries);
797 } 797 }
798 798
799 void V8DebuggerAgentImpl::schedulePauseOnNextStatement(const String16& breakReas on, PassOwnPtr<protocol::DictionaryValue> data) 799 void V8DebuggerAgentImpl::schedulePauseOnNextStatement(const String16& breakReas on, PassOwnPtr<protocol::DictionaryValue> data)
800 { 800 {
801 ASSERT(enabled()); 801 ASSERT(enabled());
802 if (m_scheduledDebuggerStep == StepInto || m_javaScriptPauseScheduled || isP aused()) 802 if (m_scheduledDebuggerStep == StepInto || m_javaScriptPauseScheduled || isP aused() || !debugger().breakpointsActivated())
803 return; 803 return;
804 m_breakReason = breakReason; 804 m_breakReason = breakReason;
805 m_breakAuxData = data; 805 m_breakAuxData = data;
806 m_pausingOnNativeEvent = true; 806 m_pausingOnNativeEvent = true;
807 m_skipNextDebuggerStepOut = false; 807 m_skipNextDebuggerStepOut = false;
808 debugger().setPauseOnNextStatement(true); 808 debugger().setPauseOnNextStatement(true);
809 } 809 }
810 810
811 void V8DebuggerAgentImpl::schedulePauseOnNextStatementIfSteppingInto() 811 void V8DebuggerAgentImpl::schedulePauseOnNextStatementIfSteppingInto()
812 { 812 {
(...skipping 745 matching lines...) Expand 10 before | Expand all | Expand 10 after
1558 } 1558 }
1559 1559
1560 bool V8DebuggerAgentImpl::canBreakProgram() 1560 bool V8DebuggerAgentImpl::canBreakProgram()
1561 { 1561 {
1562 return debugger().canBreakProgram(); 1562 return debugger().canBreakProgram();
1563 } 1563 }
1564 1564
1565 void V8DebuggerAgentImpl::breakProgram(const String16& breakReason, PassOwnPtr<p rotocol::DictionaryValue> data) 1565 void V8DebuggerAgentImpl::breakProgram(const String16& breakReason, PassOwnPtr<p rotocol::DictionaryValue> data)
1566 { 1566 {
1567 ASSERT(enabled()); 1567 ASSERT(enabled());
1568 if (m_skipAllPauses || !m_pausedContext.IsEmpty() || isCallStackEmptyOrBlack boxed()) 1568 if (m_skipAllPauses || !m_pausedContext.IsEmpty() || isCallStackEmptyOrBlack boxed() || !debugger().breakpointsActivated())
1569 return; 1569 return;
1570 m_breakReason = breakReason; 1570 m_breakReason = breakReason;
1571 m_breakAuxData = data; 1571 m_breakAuxData = data;
1572 m_scheduledDebuggerStep = NoStep; 1572 m_scheduledDebuggerStep = NoStep;
1573 m_steppingFromFramework = false; 1573 m_steppingFromFramework = false;
1574 m_pausingOnNativeEvent = false; 1574 m_pausingOnNativeEvent = false;
1575 clearStepIntoAsync(); 1575 clearStepIntoAsync();
1576 debugger().breakProgram(); 1576 debugger().breakProgram();
1577 } 1577 }
1578 1578
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
1623 return; 1623 return;
1624 m_scheduledDebuggerStep = NoStep; 1624 m_scheduledDebuggerStep = NoStep;
1625 m_scripts.clear(); 1625 m_scripts.clear();
1626 m_blackboxedPositions.clear(); 1626 m_blackboxedPositions.clear();
1627 m_breakpointIdToDebuggerBreakpointIds.clear(); 1627 m_breakpointIdToDebuggerBreakpointIds.clear();
1628 resetAsyncCallTracker(); 1628 resetAsyncCallTracker();
1629 m_promiseTracker->clear(); 1629 m_promiseTracker->clear();
1630 } 1630 }
1631 1631
1632 } // namespace blink 1632 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698