Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1822613002: Devtools: Don't show color swatch for variables like var(--blue) (Closed)

Created:
4 years, 9 months ago by samli
Modified:
4 years, 9 months ago
Reviewers:
lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-style_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Devtools: Don't show color swatch for variables like var(--blue) BUG=595231 Committed: https://crrev.com/85d68b348b4c3752d366649eb86b8d0bb34f27df Cr-Commit-Position: refs/heads/master@{#382510}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/inspector/elements/styles/url-color-swatch.html View 3 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles/url-color-swatch-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
samli
4 years, 9 months ago (2016-03-21 00:04:18 UTC) #2
lushnikov
lgtm
4 years, 9 months ago (2016-03-21 19:02:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1822613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1822613002/1
4 years, 9 months ago (2016-03-21 19:02:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oilpan_rel/builds/19670)
4 years, 9 months ago (2016-03-21 20:09:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1822613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1822613002/20001
4 years, 9 months ago (2016-03-22 02:45:26 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-22 04:43:48 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 04:45:30 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/85d68b348b4c3752d366649eb86b8d0bb34f27df
Cr-Commit-Position: refs/heads/master@{#382510}

Powered by Google App Engine
This is Rietveld 408576698