third_party/WebKit/LayoutTests/inspector/elements/styles/url-color-swatch.html - Issue 1822613002: Devtools: Don't show color swatch for variables like var(--blue)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/elements/styles/url-color-swatch.html

Issue 1822613002: Devtools: Don't show color swatch for variables like var(--blue) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/inspector/elements/styles/url-color-swatch.html

diff --git a/third_party/WebKit/LayoutTests/inspector/elements/styles/url-color-swatch.html b/third_party/WebKit/LayoutTests/inspector/elements/styles/url-color-swatch.html

index b0647df0c60769b38c8a2ce17bc755dc70d92d7e..19894891f5cc0f82645bfc5162c1d1e0240d07f1 100644

--- a/third_party/WebKit/LayoutTests/inspector/elements/styles/url-color-swatch.html

+++ b/third_party/WebKit/LayoutTests/inspector/elements/styles/url-color-swatch.html

@@ -4,6 +4,8 @@

#inspected {

background-image: url("red green blue.jpg");

color: red;

+ --blue: blue;

+ border-color: var(--blue);

}

</style>

@@ -18,6 +20,7 @@ function test()

{

dumpDOM(InspectorTest.getMatchedStylePropertyTreeItem("background-image"));

dumpDOM(InspectorTest.getMatchedStylePropertyTreeItem("color"));

+ dumpDOM(InspectorTest.getMatchedStylePropertyTreeItem("border-color"));

InspectorTest.completeTest();

}

@@ -54,6 +57,7 @@ function test()

<p>

Tests that url(...) with space-delimited color names as filename segments do not contain color swatches. Bug <a href="http://bugs.webkit.org/show_bug.cgi?id=106770">106770</a>.

+Also tests that CSS variables such as var(--blue) do not contain color swatches. Bug <a href="https://bugs.chromium.org/p/chromium/issues/detail?id=595231">595231</a>.

</p>

</body>

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/elements/styles/url-color-swatch-expected.txt » ('j') | no next file with comments »