Source/bindings/tests/results/V8TestInterfacePython.cpp - Issue 182243002: Allow the implementation to return references instead of pointers to the bindings

Unified Diff: Source/bindings/tests/results/V8TestInterfacePython.cpp

Issue 182243002: Allow the implementation to return references instead of pointers to the bindings (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/V8TestInterfaceNode.cpp ('k') | Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestInterfacePython.cpp

diff --git a/Source/bindings/tests/results/V8TestInterfacePython.cpp b/Source/bindings/tests/results/V8TestInterfacePython.cpp

index 3cb3a592efafceebe5f0fd7562f4ef222768a9cd..adbdb91a8415df46231dbfbf4eaf06a261da75d2 100644

--- a/Source/bindings/tests/results/V8TestInterfacePython.cpp

+++ b/Source/bindings/tests/results/V8TestInterfacePython.cpp

@@ -84,7 +84,7 @@ template <typename T> void V8_USE(T) { }

static void testInterfacePythonAttributeAttributeGetter(const v8::PropertyCallbackInfo<v8::Value>& info)

{

TestInterfacePythonImplementation* imp = V8TestInterfacePython::toNative(info.Holder());

- v8SetReturnValueFast(info, imp->testInterfacePythonAttribute(), imp);

+ v8SetReturnValueFast(info, WTF::getPtr(imp->testInterfacePythonAttribute()), imp);

}

static void testInterfacePythonAttributeAttributeGetterCallback(v8::Local<v8::String>, const v8::PropertyCallbackInfo<v8::Value>& info)

@@ -277,7 +277,7 @@ static void implementsNodeAttributeAttributeGetter(const v8::PropertyCallbackInf

{

TestInterfacePythonImplementation* imp = V8TestInterfacePython::toNative(info.Holder());

ASSERT(imp);

- v8SetReturnValueFast(info, TestImplements::implementsNodeAttribute(*imp), imp);

+ v8SetReturnValueFast(info, WTF::getPtr(TestImplements::implementsNodeAttribute(*imp)), imp);

}

static void implementsNodeAttributeAttributeGetterCallback(v8::Local<v8::String>, const v8::PropertyCallbackInfo<v8::Value>& info)

@@ -344,7 +344,7 @@ static void implementsRuntimeEnabledNodeAttributeAttributeGetter(const v8::Prope

{

TestInterfacePythonImplementation* imp = V8TestInterfacePython::toNative(info.Holder());

ASSERT(imp);

- v8SetReturnValueFast(info, TestImplements::implementsRuntimeEnabledNodeAttribute(*imp), imp);

+ v8SetReturnValueFast(info, WTF::getPtr(TestImplements::implementsRuntimeEnabledNodeAttribute(*imp)), imp);

}

static void implementsRuntimeEnabledNodeAttributeAttributeGetterCallback(v8::Local<v8::String>, const v8::PropertyCallbackInfo<v8::Value>& info)

@@ -379,7 +379,7 @@ static void implementsPerContextEnabledNodeAttributeAttributeGetter(const v8::Pr

{

TestInterfacePythonImplementation* imp = V8TestInterfacePython::toNative(info.Holder());

ASSERT(imp);

- v8SetReturnValueFast(info, TestImplements::implementsPerContextEnabledNodeAttribute(*imp), imp);

+ v8SetReturnValueFast(info, WTF::getPtr(TestImplements::implementsPerContextEnabledNodeAttribute(*imp)), imp);

}

static void implementsPerContextEnabledNodeAttributeAttributeGetterCallback(v8::Local<v8::String>, const v8::PropertyCallbackInfo<v8::Value>& info)