Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: Source/bindings/tests/results/V8TestEventTarget.cpp

Issue 182243002: Allow the implementation to return references instead of pointers to the bindings (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/v8_types.py ('k') | Source/bindings/tests/results/V8TestInterface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/tests/results/V8TestEventTarget.cpp
diff --git a/Source/bindings/tests/results/V8TestEventTarget.cpp b/Source/bindings/tests/results/V8TestEventTarget.cpp
index 9f1a05ed87a6622fdb672e3a4730d0ac6afa8b41..83ffa682259ed6486520d51db6cbd3a743af5640 100644
--- a/Source/bindings/tests/results/V8TestEventTarget.cpp
+++ b/Source/bindings/tests/results/V8TestEventTarget.cpp
@@ -116,7 +116,7 @@ static void indexedPropertyGetter(uint32_t index, const v8::PropertyCallbackInfo
RefPtr<Node> result = imp->item(index);
if (!result)
return;
- v8SetReturnValueFast(info, result.release(), imp);
+ v8SetReturnValueFast(info, WTF::getPtr(result.release()), imp);
}
static void indexedPropertyGetterCallback(uint32_t index, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -178,7 +178,7 @@ static void namedPropertyGetter(v8::Local<v8::String> name, const v8::PropertyCa
RefPtr<Node> result = imp->namedItem(propertyName);
if (!result)
return;
- v8SetReturnValueFast(info, result.release(), imp);
+ v8SetReturnValueFast(info, WTF::getPtr(result.release()), imp);
}
static void namedPropertyGetterCallback(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)
« no previous file with comments | « Source/bindings/scripts/v8_types.py ('k') | Source/bindings/tests/results/V8TestInterface.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698