Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1554)

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api.cc

Issue 1822303002: [Extensions] Convert APIs to use movable types [4] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/downloads/downloads_api.cc
diff --git a/chrome/browser/extensions/api/downloads/downloads_api.cc b/chrome/browser/extensions/api/downloads/downloads_api.cc
index 0a297d2116bd4a67bd2bed82ea1b9fbfa9a1556f..a1c6fff5816dc505140bdac407d6eb83e97ecab0 100644
--- a/chrome/browser/extensions/api/downloads/downloads_api.cc
+++ b/chrome/browser/extensions/api/downloads/downloads_api.cc
@@ -989,11 +989,7 @@ bool DownloadsDownloadFunction::RunAsync() {
if (options.headers.get()) {
typedef downloads::HeaderNameValuePair HeaderNameValuePair;
lazyboy 2016/03/23 21:26:58 optional nit: can get rid of this typedef since it
Devlin 2016/03/24 20:56:26 Done.
- for (std::vector<linked_ptr<HeaderNameValuePair> >::const_iterator iter =
- options.headers->begin();
- iter != options.headers->end();
- ++iter) {
- const HeaderNameValuePair& name_value = **iter;
+ for (const HeaderNameValuePair& name_value : *options.headers) {
if (!net::HttpUtil::IsValidHeaderName(name_value.name)) {
error_ = errors::kInvalidHeaderName;
return false;

Powered by Google App Engine
This is Rietveld 408576698