Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1822103004: [Offline pages] Fixing disappearing bolt when switching from incognito (Closed)

Created:
4 years, 9 months ago by fgorski
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Fixing disappearing bolt when switching from incognito This patch fixes the following issue: When switching form an incognito tab with offline page opened, to a regular tab with an offline page, the status gets updated to the correct color, but the icon disappears, or actually does not get updated. This happens when tabs are merged with other applications only, which is only affecting phones. BUG=595649 Review URL: https://codereview.chromium.org/1821003003 Cr-Commit-Position: refs/heads/master@{#382445} (cherry picked from commit eb2e9f919ec99512c32c5c7879f28d0df23cbe95) Committed: https://chromium.googlesource.com/chromium/src/+/c1e097fb6fa1e1cd303ebe2bd12d2a01267906cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
fgorski
4 years, 9 months ago (2016-03-23 15:45:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c1e097fb6fa1e1cd303ebe2bd12d2a01267906cb.

Powered by Google App Engine
This is Rietveld 408576698