Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 1821003003: [Offline pages] Fixing disappearing bolt when switching from incognito (Closed)

Created:
4 years, 9 months ago by fgorski
Modified:
4 years, 9 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Fixing disappearing bolt when switching from incognito This patch fixes the following issue: When switching form an incognito tab with offline page opened, to a regular tab with an offline page, the status gets updated to the correct color, but the icon disappears, or actually does not get updated. This happens when tabs are merged with other applications only, which is only affecting phones. BUG=595649 Committed: https://crrev.com/eb2e9f919ec99512c32c5c7879f28d0df23cbe95 Cr-Commit-Position: refs/heads/master@{#382445}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Simplifying the patch based on offline discussion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
fgorski
Ted, Please take a look.
4 years, 9 months ago (2016-03-21 20:08:11 UTC) #2
Ted C
https://codereview.chromium.org/1821003003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java File chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java (right): https://codereview.chromium.org/1821003003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java#newcode1262 chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java:1262: setOfflineStatusTint(bolt); I'm a bit confused why you need the ...
4 years, 9 months ago (2016-03-21 21:30:36 UTC) #3
fgorski
Updated code and description of the issue based on our findings offline. https://codereview.chromium.org/1821003003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java File chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java ...
4 years, 9 months ago (2016-03-21 23:15:54 UTC) #5
Ted C
lgtm
4 years, 9 months ago (2016-03-21 23:16:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1821003003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1821003003/20001
4 years, 9 months ago (2016-03-21 23:25:39 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-22 00:04:55 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 00:07:52 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eb2e9f919ec99512c32c5c7879f28d0df23cbe95
Cr-Commit-Position: refs/heads/master@{#382445}

Powered by Google App Engine
This is Rietveld 408576698