[Offline pages] Fixing disappearing bolt when switching from incognito

[Offline pages] Fixing disappearing bolt when switching from incognito

This patch fixes the following issue:
When switching form an incognito tab with offline page opened, to a regular tab with an offline page, the status gets updated to the correct color, but the icon disappears, or actually does not get updated. This happens when tabs are merged with other applications only, which is only affecting phones.

BUG=595649
Committed: https://crrev.com/eb2e9f919ec99512c32c5c7879f28d0df23cbe95
Cr-Commit-Position: refs/heads/master@{#382445}

[fgorski, 2016-03-21 20:08:10]

fgorski@chromium.org changed reviewers:
+ tedchoc@chromium.org

[fgorski, 2016-03-21 20:08:11]

Ted, Please take a look.

[Ted C, 2016-03-21 21:30:36]

https://codereview.chromium.org/1821003003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
(right):

https://codereview.chromium.org/1821003003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java:1262:
setOfflineStatusTint(bolt);
I'm a bit confused why you need the code above.

setNavigationButtonType is called from updateVisualsForState, which should cause
this to be called and a retinting should be applied.

Before we land a workaround, why doesn't this path work?

[fgorski, 2016-03-21 23:15:28]

Description was changed from

==========
[Offline pages] Fixing disappearing bolt when switching from incognito

When swithing form an incognito tab with offline page opened, to a
regular tab with an offline page, the status gets updated to the
correct color, but the icon disappears. This patch fixes that issue.

BUG=595649
==========

to

==========
[Offline pages] Fixing disappearing bolt when switching from incognito

This patch fixes the following issue:
When switching form an incognito tab with offline page opened, to a regular tab
with an offline page, the status gets updated to the correct color, but the icon
disappears, or actually does not get updated. This happens when tabs are merged
with other applications only, which is only affecting phones.


BUG=595649
==========

[fgorski, 2016-03-21 23:15:54]

Updated code and description of the issue based on our findings offline.

https://codereview.chromium.org/1821003003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
(right):

https://codereview.chromium.org/1821003003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java:1262:
setOfflineStatusTint(bolt);
On 2016/03/21 21:30:36, Ted C wrote:
> I'm a bit confused why you need the code above.
> 
> setNavigationButtonType is called from updateVisualsForState, which should
cause
> this to be called and a retinting should be applied.
> 
> Before we land a workaround, why doesn't this path work?

Based on offline discussion I replaced all the code with a call to mutate() to
invalidate the drawable.

[Ted C, 2016-03-21 23:16:32]

lgtm

[fgorski, 2016-03-21 23:25:11]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2016-03-21 23:25:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1821003003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1821003003/20001

[commit-bot: I haz the power, 2016-03-22 00:04:54]

Description was changed from

==========
[Offline pages] Fixing disappearing bolt when switching from incognito

This patch fixes the following issue:
When switching form an incognito tab with offline page opened, to a regular tab
with an offline page, the status gets updated to the correct color, but the icon
disappears, or actually does not get updated. This happens when tabs are merged
with other applications only, which is only affecting phones.


BUG=595649
==========

to

==========
[Offline pages] Fixing disappearing bolt when switching from incognito

This patch fixes the following issue:
When switching form an incognito tab with offline page opened, to a regular tab
with an offline page, the status gets updated to the correct color, but the icon
disappears, or actually does not get updated. This happens when tabs are merged
with other applications only, which is only affecting phones.


BUG=595649
==========

[commit-bot: I haz the power, 2016-03-22 00:04:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-22 00:07:51]

Description was changed from

==========
[Offline pages] Fixing disappearing bolt when switching from incognito

This patch fixes the following issue:
When switching form an incognito tab with offline page opened, to a regular tab
with an offline page, the status gets updated to the correct color, but the icon
disappears, or actually does not get updated. This happens when tabs are merged
with other applications only, which is only affecting phones.


BUG=595649
==========

to

==========
[Offline pages] Fixing disappearing bolt when switching from incognito

This patch fixes the following issue:
When switching form an incognito tab with offline page opened, to a regular tab
with an offline page, the status gets updated to the correct color, but the icon
disappears, or actually does not get updated. This happens when tabs are merged
with other applications only, which is only affecting phones.

BUG=595649

Committed: https://crrev.com/eb2e9f919ec99512c32c5c7879f28d0df23cbe95
Cr-Commit-Position: refs/heads/master@{#382445}
==========

[commit-bot: I haz the power, 2016-03-22 00:07:52]

Patchset 2 (id:??) landed as
https://crrev.com/eb2e9f919ec99512c32c5c7879f28d0df23cbe95
Cr-Commit-Position: refs/heads/master@{#382445}