Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1822103002: S390:[crankshaft] Sign-ext key before array access (Closed)

Created:
4 years, 9 months ago by JoranSiu
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390:[crankshaft] Sign-ext key before array access The 'key' value being passed into an array access should be sign-extended on 64-bit platforms before being used to index into memory. Otherwise, garbage in the upper 32-bits may result in a segmentation fault. Minor fix to DoFlooringDivI to enforce 32-bit operations for calculation. R=jyan@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com BUG= Committed: https://crrev.com/bdcefb9dc1ed225dfc3b3562d1d32458e13f342e Cr-Commit-Position: refs/heads/master@{#35000}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M src/crankshaft/s390/lithium-codegen-s390.cc View 2 chunks +17 lines, -2 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1822103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1822103002/1
4 years, 9 months ago (2016-03-22 16:53:36 UTC) #2
john.yan
lgtm
4 years, 9 months ago (2016-03-22 16:57:48 UTC) #4
JoranSiu
4 years, 9 months ago (2016-03-22 17:06:06 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-22 17:13:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1822103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1822103002/1
4 years, 9 months ago (2016-03-22 17:15:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 17:17:10 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 17:18:36 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bdcefb9dc1ed225dfc3b3562d1d32458e13f342e
Cr-Commit-Position: refs/heads/master@{#35000}

Powered by Google App Engine
This is Rietveld 408576698