Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Side by Side Diff: src/s390/macro-assembler-s390.h

Issue 1822103002: S390:[crankshaft] Sign-ext key before array access (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/s390/lithium-codegen-s390.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_S390_MACRO_ASSEMBLER_S390_H_ 5 #ifndef V8_S390_MACRO_ASSEMBLER_S390_H_
6 #define V8_S390_MACRO_ASSEMBLER_S390_H_ 6 #define V8_S390_MACRO_ASSEMBLER_S390_H_
7 7
8 #include "src/assembler.h" 8 #include "src/assembler.h"
9 #include "src/bailout-reason.h" 9 #include "src/bailout-reason.h"
10 #include "src/frames.h" 10 #include "src/frames.h"
(...skipping 1570 matching lines...) Expand 10 before | Expand all | Expand 10 after
1581 } else if (!dst.is(src)) { 1581 } else if (!dst.is(src)) {
1582 LoadRR(dst, src); 1582 LoadRR(dst, src);
1583 } 1583 }
1584 } 1584 }
1585 1585
1586 void IndexToArrayOffset(Register dst, Register src, int elementSizeLog2, 1586 void IndexToArrayOffset(Register dst, Register src, int elementSizeLog2,
1587 bool isSmi) { 1587 bool isSmi) {
1588 if (isSmi) { 1588 if (isSmi) {
1589 SmiToArrayOffset(dst, src, elementSizeLog2); 1589 SmiToArrayOffset(dst, src, elementSizeLog2);
1590 } else { 1590 } else {
1591 #if V8_TARGET_ARCH_S390X
1592 // src (key) is a 32-bit integer. Sign extension ensures
1593 // upper 32-bit does not contain garbage before being used to
1594 // reference memory.
1595 lgfr(src, src);
1596 #endif
1591 ShiftLeftP(dst, src, Operand(elementSizeLog2)); 1597 ShiftLeftP(dst, src, Operand(elementSizeLog2));
1592 } 1598 }
1593 } 1599 }
1594 1600
1595 // Untag the source value into destination and jump if source is a smi. 1601 // Untag the source value into destination and jump if source is a smi.
1596 // Souce and destination can be the same register. 1602 // Souce and destination can be the same register.
1597 void UntagAndJumpIfSmi(Register dst, Register src, Label* smi_case); 1603 void UntagAndJumpIfSmi(Register dst, Register src, Label* smi_case);
1598 1604
1599 // Untag the source value into destination and jump if source is not a smi. 1605 // Untag the source value into destination and jump if source is not a smi.
1600 // Souce and destination can be the same register. 1606 // Souce and destination can be the same register.
(...skipping 283 matching lines...) Expand 10 before | Expand all | Expand 10 after
1884 #define ACCESS_MASM(masm) \ 1890 #define ACCESS_MASM(masm) \
1885 masm->stop(__FILE_LINE__); \ 1891 masm->stop(__FILE_LINE__); \
1886 masm-> 1892 masm->
1887 #else 1893 #else
1888 #define ACCESS_MASM(masm) masm-> 1894 #define ACCESS_MASM(masm) masm->
1889 #endif 1895 #endif
1890 } // namespace internal 1896 } // namespace internal
1891 } // namespace v8 1897 } // namespace v8
1892 1898
1893 #endif // V8_S390_MACRO_ASSEMBLER_S390_H_ 1899 #endif // V8_S390_MACRO_ASSEMBLER_S390_H_
OLDNEW
« no previous file with comments | « src/crankshaft/s390/lithium-codegen-s390.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698