[presubmit] Disable linter check for alpha-sorted includes.

[presubmit] Disable linter check for alpha-sorted includes.

The linter (i.e. cpplint.py) no longer needs to check for alpha-sorted
include directives because our source formatting (i.e. clang-format)
will take care of this by now. This is the current default configuration
of the underlying linter anyways.

Note that the two tools disagree about the correct ordering about files
containing dash characters. The ordering suggested by the formatter is
more natural. Having the formatter trigger linter errors is not a good
situation to be in.

R=jochen@chromium.org

Committed: https://crrev.com/9d3e055212623f98acf6043239be68f18f3f2e5e
Cr-Commit-Position: refs/heads/master@{#34985}

[Michael Starzinger, 2016-03-22 12:07:59]

PTAL.

Note for posterity: Bug reports have been filed on both, the source formatter as
well as the linter in order to get this discrepancy fixed upstream as well. See
the following tracking issues:

https://bugs.chromium.org/p/chromium/issues/detail?id=591952
https://github.com/google/styleguide/pull/108

[Toon Verwaest, 2016-03-22 12:09:08]

verwaest@chromium.org changed reviewers:
+ verwaest@chromium.org

[Toon Verwaest, 2016-03-22 12:09:08]

Yay! LGTM

[Benedikt Meurer, 2016-03-22 12:09:19]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2016-03-22 12:09:20]

LGTM!

[jochen (gone - plz use gerrit), 2016-03-22 12:09:55]

lgtm

[Michael Starzinger, 2016-03-22 12:10:13]

Description was changed from

==========
[presubmit] Disable linter check for alpha-sorted includes.

The linter (i.e. cpplint.py) no longer needs to check for alpha-sorted
include directives because out source formatting (i.e. clang-format)
will take care of this by now. This is the current default configuration
of the underlying linter anyways.

Note that the two tools disagree about the correct ordering about files
containing dash characters. The ordering suggested by the formatter is
more natural. Having the formatter trigger linter errors is not a good
situation to be in.

R=jochen@chromium.org
==========

to

==========
[presubmit] Disable linter check for alpha-sorted includes.

The linter (i.e. cpplint.py) no longer needs to check for alpha-sorted
include directives because our source formatting (i.e. clang-format)
will take care of this by now. This is the current default configuration
of the underlying linter anyways.

Note that the two tools disagree about the correct ordering about files
containing dash characters. The ordering suggested by the formatter is
more natural. Having the formatter trigger linter errors is not a good
situation to be in.

R=jochen@chromium.org
==========

[titzer, 2016-03-22 12:12:11]

On 2016/03/22 12:09:55, jochen - slow wrote:
> lgtm

lgtm

[Michael Starzinger, 2016-03-22 12:12:49]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2016-03-22 12:12:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1822003002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1822003002/1

[commit-bot: I haz the power, 2016-03-22 12:27:02]

Description was changed from

==========
[presubmit] Disable linter check for alpha-sorted includes.

The linter (i.e. cpplint.py) no longer needs to check for alpha-sorted
include directives because our source formatting (i.e. clang-format)
will take care of this by now. This is the current default configuration
of the underlying linter anyways.

Note that the two tools disagree about the correct ordering about files
containing dash characters. The ordering suggested by the formatter is
more natural. Having the formatter trigger linter errors is not a good
situation to be in.

R=jochen@chromium.org
==========

to

==========
[presubmit] Disable linter check for alpha-sorted includes.

The linter (i.e. cpplint.py) no longer needs to check for alpha-sorted
include directives because our source formatting (i.e. clang-format)
will take care of this by now. This is the current default configuration
of the underlying linter anyways.

Note that the two tools disagree about the correct ordering about files
containing dash characters. The ordering suggested by the formatter is
more natural. Having the formatter trigger linter errors is not a good
situation to be in.

R=jochen@chromium.org
==========

[commit-bot: I haz the power, 2016-03-22 12:27:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-22 12:27:20]

Description was changed from

==========
[presubmit] Disable linter check for alpha-sorted includes.

The linter (i.e. cpplint.py) no longer needs to check for alpha-sorted
include directives because our source formatting (i.e. clang-format)
will take care of this by now. This is the current default configuration
of the underlying linter anyways.

Note that the two tools disagree about the correct ordering about files
containing dash characters. The ordering suggested by the formatter is
more natural. Having the formatter trigger linter errors is not a good
situation to be in.

R=jochen@chromium.org
==========

to

==========
[presubmit] Disable linter check for alpha-sorted includes.

The linter (i.e. cpplint.py) no longer needs to check for alpha-sorted
include directives because our source formatting (i.e. clang-format)
will take care of this by now. This is the current default configuration
of the underlying linter anyways.

Note that the two tools disagree about the correct ordering about files
containing dash characters. The ordering suggested by the formatter is
more natural. Having the formatter trigger linter errors is not a good
situation to be in.

R=jochen@chromium.org

Committed: https://crrev.com/9d3e055212623f98acf6043239be68f18f3f2e5e
Cr-Commit-Position: refs/heads/master@{#34985}
==========

[commit-bot: I haz the power, 2016-03-22 12:27:21]

Patchset 1 (id:??) landed as
https://crrev.com/9d3e055212623f98acf6043239be68f18f3f2e5e
Cr-Commit-Position: refs/heads/master@{#34985}