Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Side by Side Diff: tools/presubmit.py

Issue 1822003002: [presubmit] Disable linter check for alpha-sorted includes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # 2 #
3 # Copyright 2012 the V8 project authors. All rights reserved. 3 # Copyright 2012 the V8 project authors. All rights reserved.
4 # Redistribution and use in source and binary forms, with or without 4 # Redistribution and use in source and binary forms, with or without
5 # modification, are permitted provided that the following conditions are 5 # modification, are permitted provided that the following conditions are
6 # met: 6 # met:
7 # 7 #
8 # * Redistributions of source code must retain the above copyright 8 # * Redistributions of source code must retain the above copyright
9 # notice, this list of conditions and the following disclaimer. 9 # notice, this list of conditions and the following disclaimer.
10 # * Redistributions in binary form must reproduce the above 10 # * Redistributions in binary form must reproduce the above
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 from testrunner.local import utils 51 from testrunner.local import utils
52 52
53 # Special LINT rules diverging from default and reason. 53 # Special LINT rules diverging from default and reason.
54 # build/header_guard: Our guards have the form "V8_FOO_H_", not "SRC_FOO_H_". 54 # build/header_guard: Our guards have the form "V8_FOO_H_", not "SRC_FOO_H_".
55 # build/include_what_you_use: Started giving false positives for variables 55 # build/include_what_you_use: Started giving false positives for variables
56 # named "string" and "map" assuming that you needed to include STL headers. 56 # named "string" and "map" assuming that you needed to include STL headers.
57 # TODO(bmeurer): Fix and re-enable readability/check 57 # TODO(bmeurer): Fix and re-enable readability/check
58 58
59 LINT_RULES = """ 59 LINT_RULES = """
60 -build/header_guard 60 -build/header_guard
61 +build/include_alpha
62 -build/include_what_you_use 61 -build/include_what_you_use
63 -build/namespaces 62 -build/namespaces
64 -readability/check 63 -readability/check
65 +readability/streams 64 +readability/streams
66 -runtime/references 65 -runtime/references
67 """.split() 66 """.split()
68 67
69 LINT_OUTPUT_PATTERN = re.compile(r'^.+[:(]\d+[:)]|^Done processing') 68 LINT_OUTPUT_PATTERN = re.compile(r'^.+[:(]\d+[:)]|^Done processing')
70 FLAGS_LINE = re.compile("//\s*Flags:.*--([A-z0-9-])+_[A-z0-9].*\n") 69 FLAGS_LINE = re.compile("//\s*Flags:.*--([A-z0-9-])+_[A-z0-9].*\n")
71 70
(...skipping 415 matching lines...) Expand 10 before | Expand all | Expand 10 after
487 success &= CheckExternalReferenceRegistration(workspace) 486 success &= CheckExternalReferenceRegistration(workspace)
488 success &= CheckStatusFiles(workspace) 487 success &= CheckStatusFiles(workspace)
489 if success: 488 if success:
490 return 0 489 return 0
491 else: 490 else:
492 return 1 491 return 1
493 492
494 493
495 if __name__ == '__main__': 494 if __name__ == '__main__':
496 sys.exit(Main()) 495 sys.exit(Main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698