Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1821913002: Revert of Quit the message loop by default in ShellConnectionLost when ApplicationRunner is used (Closed)

Created:
4 years, 9 months ago by esprehn
Modified:
4 years, 9 months ago
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Quit the message loop by default in ShellConnectionLost when ApplicationRunner is used (patchset #2 id:20001 of https://codereview.chromium.org/1819063002/ ) Reason for revert: Looks like to made the mojo_apptests go red. I think this is also making MUS tests fail? https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/39128 Original issue's description: > Quit the message loop by default in ShellConnectionLost when ApplicationRunner is used > > This was originally at https://codereview.chromium.org/1814223002/ , but Ben is out and > I need this for tests, so I'm taking over. > > BUG=none > TEST=covered by tests > TBR=ben@chromium.org > R=ben@chromium.org > > Committed: https://crrev.com/a50f9840749052fbdec087a304548217cc6fd00b > Cr-Commit-Position: refs/heads/master@{#382389} TBR=ben@chromium.org,sky@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/0ebf9a924d744ef98948ecb4f5d9e9a6fd3b42bf Cr-Commit-Position: refs/heads/master@{#382460}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -40 lines) Patch
M ash/mus/sysui_application.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/mus/sysui_application.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M components/filesystem/file_system_app.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/filesystem/file_system_app.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/font_service/font_service_app.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/font_service/font_service_app.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/leveldb/leveldb_app.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/leveldb/leveldb_app.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M components/mus/mus_app.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/mus_app.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M components/resource_provider/resource_provider_app.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/resource_provider/resource_provider_app.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M mash/browser_driver/browser_driver_application_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M mash/browser_driver/browser_driver_application_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mash/quick_launch/quick_launch_application.h View 1 chunk +1 line, -0 lines 0 comments Download
M mash/quick_launch/quick_launch_application.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M mash/wm/window_manager_application.h View 1 chunk +1 line, -0 lines 0 comments Download
M mash/wm/window_manager_application.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/services/network/network_service_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/network/network_service_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/services/tracing/tracing_app.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/tracing/tracing_app.cc View 1 chunk +1 line, -5 lines 0 comments Download
M mojo/shell/background/tests/test_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/public/cpp/lib/application_runner.cc View 2 chunks +1 line, -5 lines 0 comments Download
M mojo/shell/public/cpp/lib/shell_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/public/cpp/lib/shell_connection.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/shell/public/cpp/shell_client.h View 1 chunk +2 lines, -7 lines 0 comments Download
M mojo/shell/public/cpp/shell_connection.h View 2 chunks +1 line, -8 lines 0 comments Download
M mojo/shell/tests/connect/connect_test_app.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/shell/tests/connect/connect_test_driver.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/shell/tests/connect/connect_test_package.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/shell/tests/lifecycle/app_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/shell/tests/lifecycle/app_client.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
esprehn
Created Revert of Quit the message loop by default in ShellConnectionLost when ApplicationRunner is used
4 years, 9 months ago (2016-03-22 00:39:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1821913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1821913002/1
4 years, 9 months ago (2016-03-22 00:40:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 00:41:16 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 00:43:27 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ebf9a924d744ef98948ecb4f5d9e9a6fd3b42bf
Cr-Commit-Position: refs/heads/master@{#382460}

Powered by Google App Engine
This is Rietveld 408576698