Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1668)

Unified Diff: mojo/services/tracing/tracing_app.cc

Issue 1821913002: Revert of Quit the message loop by default in ShellConnectionLost when ApplicationRunner is used (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/services/tracing/tracing_app.h ('k') | mojo/shell/background/tests/test_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/services/tracing/tracing_app.cc
diff --git a/mojo/services/tracing/tracing_app.cc b/mojo/services/tracing/tracing_app.cc
index d921a6d97b9d00038f049795a527f16b3a0c45fc..65b44219b2540cfda0d94528acf450701136f6c6 100644
--- a/mojo/services/tracing/tracing_app.cc
+++ b/mojo/services/tracing/tracing_app.cc
@@ -42,12 +42,8 @@
return true;
}
-bool TracingApp::ShellConnectionLost() {
- // TODO(beng): This is only required because TracingApp isn't run by
- // ApplicationRunner - instead it's launched automatically by the standalone
- // shell. It shouldn't be.
+void TracingApp::ShellConnectionLost() {
base::MessageLoop::current()->QuitWhenIdle();
- return false;
}
void TracingApp::Create(mojo::Connection* connection,
« no previous file with comments | « mojo/services/tracing/tracing_app.h ('k') | mojo/shell/background/tests/test_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698