Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 1821773003: Fix match default behavior on strings for ES2015 semantics (Closed)

Created:
4 years, 9 months ago by Dan Ehrenberg
Modified:
4 years, 9 months ago
Reviewers:
Yang
CC:
adamk, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix match default behavior on strings for ES2015 semantics String.prototype.match is specified to call out to the current value of RegExp.prototype[Symbol.match] when passed a string argument, rather than the original value. This patch updates the RegExp code to do that. R=yangguo@chromium.org BUG=v8:4602 LOG=Y Committed: https://crrev.com/64b2b1ac3397bd8ec06c57547c50d895f47d93d7 Cr-Commit-Position: refs/heads/master@{#35001}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M src/js/regexp.js View 1 chunk +0 lines, -1 line 0 comments Download
M src/js/string.js View 3 chunks +1 line, -3 lines 0 comments Download
M test/test262/test262.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1821773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1821773003/1
4 years, 9 months ago (2016-03-22 00:15:28 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-22 00:48:51 UTC) #4
Dan Ehrenberg
4 years, 9 months ago (2016-03-22 01:05:46 UTC) #5
Yang
On 2016/03/22 01:05:46, Dan Ehrenberg wrote: lgtm
4 years, 9 months ago (2016-03-22 05:45:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1821773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1821773003/1
4 years, 9 months ago (2016-03-22 17:22:41 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 17:24:57 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 17:26:02 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/64b2b1ac3397bd8ec06c57547c50d895f47d93d7
Cr-Commit-Position: refs/heads/master@{#35001}

Powered by Google App Engine
This is Rietveld 408576698