src/js/string.js - Issue 1821773003: Fix match default behavior on strings for ES2015 semantics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/js/string.js

Issue 1821773003: Fix match default behavior on strings for ES2015 semantics (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/js/string.js

diff --git a/src/js/string.js b/src/js/string.js

index 8cab5bb601159623df48eb3cbdfcd8ecf2600b02..40fc099709fa5d6eb94baadf42bb20e000c91c78 100644

--- a/src/js/string.js

+++ b/src/js/string.js

@@ -21,7 +21,6 @@ var MakeTypeError;

var MaxSimple;

var MinSimple;

var matchSymbol = utils.ImportNow("match_symbol");

-var RegExpExecNoTests;

var replaceSymbol = utils.ImportNow("replace_symbol");

var searchSymbol = utils.ImportNow("search_symbol");

var splitSymbol = utils.ImportNow("split_symbol");

@@ -34,7 +33,6 @@ utils.Import(function(from) {

MakeTypeError = from.MakeTypeError;

MaxSimple = from.MaxSimple;

MinSimple = from.MinSimple;

- RegExpExecNoTests = from.RegExpExecNoTests;

});

//-------------------------------------------------------------------

@@ -163,7 +161,7 @@ function StringMatchJS(pattern) {

// Non-regexp argument.

var regexp = new GlobalRegExp(pattern);

- return RegExpExecNoTests(regexp, subject, 0);

+ return regexp[matchSymbol](subject);

}

« no previous file with comments | « src/js/regexp.js ('k') | test/test262/test262.status » ('j') | no next file with comments »