Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 1821753002: media: Allow WMPI to send playing started notification while playing (Closed)

Created:
4 years, 9 months ago by watk
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

media: Allow WMPI to send playing started notification while playing Previously MediaWebContentsObserver DCHECKed that an active player was never added twice. To avoid complicated logic in WMPI to keep track of when it's okay to send a playing notification to MediaWebContentsObserver, now it's allowed to send it more than once. BUG=595903, 595970 Review URL: https://codereview.chromium.org/1810213002 Cr-Commit-Position: refs/heads/master@{#382098} (cherry picked from commit 73fd2eb18f1ed48a1047d737a9db170608ac6f47) Committed: https://chromium.googlesource.com/chromium/src/+/217c5e96c255d046fce4a1743b560e7ee5625a82

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M content/browser/media/media_web_contents_observer.h View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/media/media_web_contents_observer.cc View 2 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
watk
4 years, 9 months ago (2016-03-21 18:10:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
217c5e96c255d046fce4a1743b560e7ee5625a82.

Powered by Google App Engine
This is Rietveld 408576698