Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1810213002: media: Allow WMPI to send playing started notification while playing (Closed)

Created:
4 years, 9 months ago by watk
Modified:
4 years, 9 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Allow WMPI to send playing started notification while playing Previously MediaWebContentsObserver DCHECKed that an active player was never added twice. To avoid complicated logic in WMPI to keep track of when it's okay to send a playing notification to MediaWebContentsObserver, now it's allowed to send it more than once. BUG=595903, 595970 Committed: https://crrev.com/73fd2eb18f1ed48a1047d737a9db170608ac6f47 Cr-Commit-Position: refs/heads/master@{#382098}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M content/browser/media/media_web_contents_observer.h View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/media/media_web_contents_observer.cc View 2 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
watk
4 years, 9 months ago (2016-03-17 22:56:29 UTC) #2
DaleCurtis
lgtm
4 years, 9 months ago (2016-03-17 23:11:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810213002/1
4 years, 9 months ago (2016-03-18 20:34:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 21:46:06 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 21:47:58 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73fd2eb18f1ed48a1047d737a9db170608ac6f47
Cr-Commit-Position: refs/heads/master@{#382098}

Powered by Google App Engine
This is Rietveld 408576698