Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 1821733002: [Media Router] Disable focus if not triggered by user. (Closed)

Created:
4 years, 9 months ago by apacible
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

[Media Router] Disable focus if not triggered by user. In some cases such as page load, an unexpected focus event is triggered separately from any user input (e.g. tab or click). Disable this without disabling focus in general; focus is still needed for accessibility reasons. BUG=593221 Review URL: https://codereview.chromium.org/1799303002 Cr-Commit-Position: refs/heads/master@{#381130} (cherry picked from commit 280874bcce6eaa1b31d65fcdbe7f31bdfe191434) Committed: https://chromium.googlesource.com/chromium/src/+/32ccd64cce0c370052e2ef1ba2d4421a73de2f56

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -13 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_header/media_router_header.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js View 3 chunks +30 lines, -12 lines 0 comments Download
M chrome/browser/resources/media_router/externs.js View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
apacible
4 years, 9 months ago (2016-03-21 18:02:05 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
32ccd64cce0c370052e2ef1ba2d4421a73de2f56.

Powered by Google App Engine
This is Rietveld 408576698