[Media Router] Disable focus if not triggered by user.

[Media Router] Disable focus if not triggered by user.

In some cases such as page load, an unexpected focus event is triggered separately from any user input (e.g. tab or click). Disable this without disabling focus in general; focus is still needed for accessibility reasons.

BUG=593221
Committed: https://crrev.com/280874bcce6eaa1b31d65fcdbe7f31bdfe191434
Cr-Commit-Position: refs/heads/master@{#381130}

[apacible, 2016-03-14 23:24:37]

Description was changed from

==========
[Media Router] Disable page on load focus.

BUG=593221
==========

to

==========
[Media Router] Disable focus if not triggered by user.

In some cases such as page load, an unexpected focus event is triggered
separately from any user input (e.g. tab or click). Disable this without
disabling focus in general; focus is still needed for accessibility reasons.

BUG=593221
==========

[apacible, 2016-03-14 23:24:37]

apacible@chromium.org changed reviewers:
+ imcheng@chromium.org

[apacible, 2016-03-14 23:24:47]

PTAL, thanks!

[imcheng, 2016-03-14 23:34:51]

lgtm

Looks fine. Just one comment. Also, do we know why does the focus event fire
sometimes?

https://codereview.chromium.org/1799303002/diff/1/chrome/browser/resources/me...
File
chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js
(right):

https://codereview.chromium.org/1799303002/diff/1/chrome/browser/resources/me...
chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js:169:
event.path[0].blur();
would that cause blur event to fire?
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...

[apacible, 2016-03-14 23:53:37]

> Also, do we know why does the focus event fire sometimes?

In general, if there was something focused and the user had tabbed away and
back, a focus event will be triggered to show the ripple on the event. This is
by design in Polymer (paper-behavior).

For our particular case, no. After a couple days of looking into this with some
folks more familiar with the implementation of this behavior, we haven't figured
the root cause for the focus event firing unexpectedly. This patch will resolve
the issue in the meantime.

https://codereview.chromium.org/1799303002/diff/1/chrome/browser/resources/me...
File
chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js
(right):

https://codereview.chromium.org/1799303002/diff/1/chrome/browser/resources/me...
chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js:169:
event.path[0].blur();
On 2016/03/14 23:34:50, imcheng wrote:
> would that cause blur event to fire?
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...

No, this only blurs the specific element.

[apacible, 2016-03-14 23:53:48]

The CQ bit was checked by apacible@chromium.org

[commit-bot: I haz the power, 2016-03-14 23:54:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1799303002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1799303002/1

[commit-bot: I haz the power, 2016-03-15 00:27:24]

Description was changed from

==========
[Media Router] Disable focus if not triggered by user.

In some cases such as page load, an unexpected focus event is triggered
separately from any user input (e.g. tab or click). Disable this without
disabling focus in general; focus is still needed for accessibility reasons.

BUG=593221
==========

to

==========
[Media Router] Disable focus if not triggered by user.

In some cases such as page load, an unexpected focus event is triggered
separately from any user input (e.g. tab or click). Disable this without
disabling focus in general; focus is still needed for accessibility reasons.

BUG=593221
==========

[commit-bot: I haz the power, 2016-03-15 00:27:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-15 00:28:33]

Description was changed from

==========
[Media Router] Disable focus if not triggered by user.

In some cases such as page load, an unexpected focus event is triggered
separately from any user input (e.g. tab or click). Disable this without
disabling focus in general; focus is still needed for accessibility reasons.

BUG=593221
==========

to

==========
[Media Router] Disable focus if not triggered by user.

In some cases such as page load, an unexpected focus event is triggered
separately from any user input (e.g. tab or click). Disable this without
disabling focus in general; focus is still needed for accessibility reasons.

BUG=593221

Committed: https://crrev.com/280874bcce6eaa1b31d65fcdbe7f31bdfe191434
Cr-Commit-Position: refs/heads/master@{#381130}
==========

[commit-bot: I haz the power, 2016-03-15 00:28:33]

Patchset 1 (id:??) landed as
https://crrev.com/280874bcce6eaa1b31d65fcdbe7f31bdfe191434
Cr-Commit-Position: refs/heads/master@{#381130}