Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1821633002: [telemetry] Don't include "" in the --js-flag args used in v8 benchmarks (Closed)

Created:
4 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 9 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[telemetry] Don't include "" in the --js-flag args used in v8 benchmarks The "" would only be required by a shell, adding them here actually breaks parsing of those flags R=ulan@chromium.org,cbruni@chromium.org,rmcilroy@chromium.org,skyostil@chromium.org BUG=chromium:593406, v8:4280 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect Committed: https://crrev.com/caa9a399a5044478446cf442494414ce7927658c Cr-Commit-Position: refs/heads/master@{#382293}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/perf/benchmarks/v8.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
jochen (gone - plz use gerrit)
4 years, 9 months ago (2016-03-21 12:53:19 UTC) #1
Camillo Bruni
lgtm
4 years, 9 months ago (2016-03-21 12:54:52 UTC) #2
Sami
lgtm.
4 years, 9 months ago (2016-03-21 13:05:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1821633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1821633002/1
4 years, 9 months ago (2016-03-21 13:05:35 UTC) #5
rmcilroy
On 2016/03/21 13:05:35, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 9 months ago (2016-03-21 13:32:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/120207)
4 years, 9 months ago (2016-03-21 14:52:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1821633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1821633002/1
4 years, 9 months ago (2016-03-21 14:55:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 15:29:22 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 15:30:34 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/caa9a399a5044478446cf442494414ce7927658c
Cr-Commit-Position: refs/heads/master@{#382293}

Powered by Google App Engine
This is Rietveld 408576698