Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: tools/perf/benchmarks/v8.py

Issue 1821633002: [telemetry] Don't include "" in the --js-flag args used in v8 benchmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/v8.py
diff --git a/tools/perf/benchmarks/v8.py b/tools/perf/benchmarks/v8.py
index ca77615118192b86bf0ea68f484c2f45622894aa..4d5a82dbdd0f45c8bc023bec07e9fa6fc24e6fc3 100644
--- a/tools/perf/benchmarks/v8.py
+++ b/tools/perf/benchmarks/v8.py
@@ -81,7 +81,7 @@ class _InfiniteScrollBenchmark(perf_benchmark.PerfBenchmark):
'--disable-notifications',
# This overrides any existing --js-flags, hence we have to include the
# previous flags as well.
- '--js-flags="--heap-growing-percent=10 %s"' %
+ '--js-flags=--heap-growing-percent=10 %s' %
(' '.join(existing_js_flags))
])
@@ -154,7 +154,7 @@ class V8TodoMVCIgnition(perf_benchmark.PerfBenchmark):
options.AppendExtraBrowserArgs([
# This overrides any existing --js-flags, hence we have to include the
# previous flags as well.
- '--js-flags="--ignition %s"' % (' '.join(existing_js_flags))
+ '--js-flags=--ignition %s' % (' '.join(existing_js_flags))
])
def CreateTimelineBasedMeasurementOptions(self):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698