Issue 26044. Cache and use LibraryElementImpl.exportNamespace.

Issue 26044. Cache and use LibraryElementImpl.exportNamespace.

This makes Flutter analysis 20% faster.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/26044

Committed: https://github.com/dart-lang/sdk/commit/97759f471cdb68ce1bb41360c429bc175b099d0b

[Brian Wilkerson, 2016-03-20 21:26:29]

LGTM

https://codereview.chromium.org/1821543002/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/cache.dart (right):

https://codereview.chromium.org/1821543002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/cache.dart:1064: ResultDescriptor descriptor,
CacheState state, Object value) {
I'm not seeing where the state is used, but maybe I'm just missing something.

https://codereview.chromium.org/1821543002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/1821543002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:6768: library.exportNamespace = new
Namespace(exportMapping);
Shouldn't we just return 'exportMapping' at this point? It looks like not doing
so will cause us to re-compute the mapping.

[scheglov, 2016-03-20 22:16:47]

https://codereview.chromium.org/1821543002/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/cache.dart (right):

https://codereview.chromium.org/1821543002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/cache.dart:1064: ResultDescriptor descriptor,
CacheState state, Object value) {
On 2016/03/20 21:26:29, Brian Wilkerson wrote:
> I'm not seeing where the state is used, but maybe I'm just missing something.

No, you're not missing.
I thought that maybe it would be useful to provide it when we provide value, but
given that this is not API we can add it later if we would need it.

https://codereview.chromium.org/1821543002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/1821543002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:6768: library.exportNamespace = new
Namespace(exportMapping);
On 2016/03/20 21:26:29, Brian Wilkerson wrote:
> Shouldn't we just return 'exportMapping' at this point? It looks like not
doing
> so will cause us to re-compute the mapping.

Fixed.
Thanks!

[scheglov, 2016-03-20 22:17:00]

Description was changed from

==========
Issue 26044. Cache and use LibraryElementImpl.exportNamespace.

This makes Flutter analysis 20% faster.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/26044
==========

to

==========
Issue 26044. Cache and use LibraryElementImpl.exportNamespace.

This makes Flutter analysis 20% faster.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/26044

Committed:
https://github.com/dart-lang/sdk/commit/97759f471cdb68ce1bb41360c429bc175b099d0b
==========

[scheglov, 2016-03-20 22:17:03]

Committed patchset #1 (id:1) manually as
97759f471cdb68ce1bb41360c429bc175b099d0b (presubmit successful).