Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: pkg/analyzer/lib/src/context/cache.dart

Issue 1821543002: Issue 26044. Cache and use LibraryElementImpl.exportNamespace. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/context/cache.dart
diff --git a/pkg/analyzer/lib/src/context/cache.dart b/pkg/analyzer/lib/src/context/cache.dart
index eb65a4e4091183d17e64bebb3e347860e2e51a06..3db74f9dc1ba47693c08aa01f6bf4fbaa02d885e 100644
--- a/pkg/analyzer/lib/src/context/cache.dart
+++ b/pkg/analyzer/lib/src/context/cache.dart
@@ -565,7 +565,8 @@ class CacheEntry {
// Ask the delta to validate.
DeltaResult deltaResult = null;
if (delta != null) {
- deltaResult = delta.validate(_partition.context, target, descriptor);
+ deltaResult = delta.validate(_partition.context, target, descriptor,
+ thisData.state, thisData.value);
if (deltaResult == DeltaResult.STOP) {
return;
}
@@ -1056,10 +1057,11 @@ class Delta {
/**
* Check whether this delta affects the result described by the given
- * [descriptor] and [target].
+ * [descriptor] and [target]. The current [state] and [value] of the result
+ * are provided.
*/
DeltaResult validate(InternalAnalysisContext context, AnalysisTarget target,
- ResultDescriptor descriptor) {
+ ResultDescriptor descriptor, CacheState state, Object value) {
Brian Wilkerson 2016/03/20 21:26:29 I'm not seeing where the state is used, but maybe
scheglov 2016/03/20 22:16:46 No, you're not missing. I thought that maybe it wo
return DeltaResult.INVALIDATE;
}
}
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/generated/incremental_resolver.dart » ('j') | pkg/analyzer/lib/src/generated/resolver.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698