Issue 1821433002: [UI Views] Check menu() in ZoomView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1821433002: [UI Views] Check menu() in ZoomView (Closed)

Created:
4 years, 9 months ago by Devlin

Modified:
4 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2661

Target Ref:
refs/pending/branch-heads/2661

Project:
chromium

Visibility:
Public.

[UI Views] Check menu() in ZoomView AppMenuView::menu() documents that it may be null during shutdown, but ZoomView doesn't check it. Add a check. BUG=594055 Review URL: https://codereview.chromium.org/1803003003 Cr-Commit-Position: refs/heads/master@{#381329} (cherry picked from commit 03ad6f33b5e9d4f3b22cfd6cda5fab9002fe52d6) Committed: https://chromium.googlesource.com/chromium/src/+/0b91862628b99b50dc811079000d0b16c48c4269

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -7 lines)			Patch
	M	chrome/browser/ui/views/toolbar/app_menu.cc	View		2 chunks	+8 lines, -7 lines	0 comments	Download

Total messages: 2 (1 generated)

Devlin

4 years, 9 months ago (2016-03-18 22:51:26 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0b91862628b99b50dc811079000d0b16c48c4269.