Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1803003003: [UI Views] Check menu() in ZoomView (Closed)

Created:
4 years, 9 months ago by Devlin
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[UI Views] Check menu() in ZoomView AppMenuView::menu() documents that it may be null during shutdown, but ZoomView doesn't check it. Add a check. BUG=594055 Committed: https://crrev.com/03ad6f33b5e9d4f3b22cfd6cda5fab9002fe52d6 Cr-Commit-Position: refs/heads/master@{#381329}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M chrome/browser/ui/views/toolbar/app_menu.cc View 2 chunks +8 lines, -7 lines 1 comment Download

Messages

Total messages: 8 (3 generated)
Devlin
https://codereview.chromium.org/1803003003/diff/1/chrome/browser/ui/views/toolbar/app_menu.cc File chrome/browser/ui/views/toolbar/app_menu.cc (left): https://codereview.chromium.org/1803003003/diff/1/chrome/browser/ui/views/toolbar/app_menu.cc#oldcode651 chrome/browser/ui/views/toolbar/app_menu.cc:651: void AppMenuDestroyed() override { AppMenuView::AppMenuDestroyed(); } Drive-by: this was ...
4 years, 9 months ago (2016-03-15 21:39:22 UTC) #2
sky
LGTM
4 years, 9 months ago (2016-03-15 21:44:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1803003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1803003003/1
4 years, 9 months ago (2016-03-15 21:50:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-15 21:56:27 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 21:58:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/03ad6f33b5e9d4f3b22cfd6cda5fab9002fe52d6
Cr-Commit-Position: refs/heads/master@{#381329}

Powered by Google App Engine
This is Rietveld 408576698