Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pdfium.gyp

Issue 1821423002: Re-enable MSVC warning 4702 (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: address comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« core/fxcrt/fx_basic_memmgr.cpp ('K') | « fpdfsdk/javascript/JS_EventHandler.cpp ('k') | third_party/base/logging.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdfium.gyp
diff --git a/pdfium.gyp b/pdfium.gyp
index a5a70a8033aeb5d8d4c15e014f882124df9f7c12..f43f58d98522a1a2e3ab37bcccd83ee49aaf5944 100644
--- a/pdfium.gyp
+++ b/pdfium.gyp
@@ -95,8 +95,6 @@
],
'msvs_disabled_warnings': [
4005, 4018, 4146, 4333, 4345, 4267,
- # TODO(thestig): Fix all instances, remove this, pdfium:29
- 4702,
],
'variables': {
'clang_warning_flags': [
« core/fxcrt/fx_basic_memmgr.cpp ('K') | « fpdfsdk/javascript/JS_EventHandler.cpp ('k') | third_party/base/logging.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698