Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Side by Side Diff: pdfium.gyp

Issue 1821423002: Re-enable MSVC warning 4702 (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: address comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 PDFium Authors. All rights reserved. 1 # Copyright 2015 PDFium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 # TODO(thakis): Enable this, pdfium:29 7 # TODO(thakis): Enable this, pdfium:29
8 #'chromium_code': 1, 8 #'chromium_code': 1,
9 9
10 'variables': { 10 'variables': {
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 ], 88 ],
89 }], 89 }],
90 ['clang==1 and clang_use_pdfium_plugins==1', { 90 ['clang==1 and clang_use_pdfium_plugins==1', {
91 'cflags': [ 91 'cflags': [
92 '<@(clang_pdfium_plugins_flags)', 92 '<@(clang_pdfium_plugins_flags)',
93 ], 93 ],
94 }], 94 }],
95 ], 95 ],
96 'msvs_disabled_warnings': [ 96 'msvs_disabled_warnings': [
97 4005, 4018, 4146, 4333, 4345, 4267, 97 4005, 4018, 4146, 4333, 4345, 4267,
98 # TODO(thestig): Fix all instances, remove this, pdfium:29
99 4702,
100 ], 98 ],
101 'variables': { 99 'variables': {
102 'clang_warning_flags': [ 100 'clang_warning_flags': [
103 # TODO(thestig): Fix all instances, remove this, pdfium:29 101 # TODO(thestig): Fix all instances, remove this, pdfium:29
104 '-Wno-sign-compare', 102 '-Wno-sign-compare',
105 ], 103 ],
106 # Make sure Chromium's build/common.gypi doesn't re-add the flag on linux. 104 # Make sure Chromium's build/common.gypi doesn't re-add the flag on linux.
107 'cflags_cc!': [ '-Wsign-compare' ], 105 'cflags_cc!': [ '-Wsign-compare' ],
108 }, 106 },
109 }, 107 },
(...skipping 902 matching lines...) Expand 10 before | Expand all | Expand 10 after
1012 'fpdfsdk/include/fpdfxfa/fpdfxfa_app.h', 1010 'fpdfsdk/include/fpdfxfa/fpdfxfa_app.h',
1013 'fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h', 1011 'fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h',
1014 'fpdfsdk/include/fpdfxfa/fpdfxfa_page.h', 1012 'fpdfsdk/include/fpdfxfa/fpdfxfa_page.h',
1015 'fpdfsdk/include/fpdfxfa/fpdfxfa_util.h', 1013 'fpdfsdk/include/fpdfxfa/fpdfxfa_util.h',
1016 ], 1014 ],
1017 }, 1015 },
1018 ] 1016 ]
1019 }], 1017 }],
1020 ] 1018 ]
1021 } 1019 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698