core/fxcrt/fx_basic_memmgr.cpp - Issue 1821423002: Re-enable MSVC warning 4702

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcrt/fx_basic_memmgr.cpp

Issue 1821423002: Re-enable MSVC warning 4702 (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: address comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxcrt/fx_basic_memmgr.cpp

diff --git a/core/fxcrt/fx_basic_memmgr.cpp b/core/fxcrt/fx_basic_memmgr.cpp

index a0af6aef6d7a4aab0566008a0feb0e9bf8440482..1cbd293006b5e4e1cd37530739936132fb574d60 100644

--- a/core/fxcrt/fx_basic_memmgr.cpp

+++ b/core/fxcrt/fx_basic_memmgr.cpp

@@ -21,5 +21,7 @@ void FXMEM_DefaultFree(void* pointer, int flags) {

NEVER_INLINE void FX_OutOfMemoryTerminate() {

// Termimate cleanly if we can, else crash at a specific address (0xbd).

abort();

+#ifndef _WIN32

reinterpret_cast<void (*)()>(0xbd)();

Tom Sepez 2016/03/23 16:49:50 This could be NULL_DEREF_IF_POSSIBLE, too.

Wei Li 2016/03/23 18:15:12 I thought this was intentional to be set as a diff

+#endif

}

« no previous file with comments | « core/fxcodec/jbig2/JBig2_GsidProc.cpp ('k') | core/fxge/dib/fx_dib_convert.cpp » ('j') | no next file with comments »